Issue 17286007: few steps in the direction of to encapsulating podofo, so the client is not aware podofo is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17286007: few steps in the direction of to encapsulating podofo, so the client is not aware podofo is used. (Closed)

Created:
7 years, 6 months ago by edisonn

Modified:
7 years, 6 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

few steps in the direction of to encapsulating podofo, so the client is not aware podofo is used. Committed: https://code.google.com/p/skia/source/detail?r=9643

Created: 7 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3351 lines, -796 lines)			Patch
M	experimental/PdfViewer/generate_code.py	View	1	4 chunks	+15 lines, -9 lines	0 comments	Download
M	experimental/PdfViewer/pdf_auto_gen.h	View		520 chunks	+2992 lines, -714 lines	0 comments	Download
M	experimental/PdfViewer/pdf_viewer_main.cpp	View	1	17 chunks	+79 lines, -29 lines	0 comments	Download
M	experimental/PdfViewer/pdfspec_autogen.py	View	1	3 chunks	+220 lines, -25 lines	0 comments	Download
M	experimental/PdfViewer/spec2def.py	View	1	8 chunks	+45 lines, -19 lines	0 comments	Download

Total messages: 1 (0 generated)

edisonn

7 years, 6 months ago (2013-06-17 20:46:36 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r9643 (presubmit successful).