src/runtime/runtime-function.cc - Issue 1728593002: [Interpreter] Add support for cpu profiler logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-function.cc

Issue 1728593002: [Interpreter] Add support for cpu profiler logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address review feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-function.cc

diff --git a/src/runtime/runtime-function.cc b/src/runtime/runtime-function.cc

index d424a9ebfeb262592044d6712a8498e20c7d19c7..33e6ae11f9eb400f43b774a4c3c063e575aa69c6 100644

--- a/src/runtime/runtime-function.cc

+++ b/src/runtime/runtime-function.cc

@@ -204,8 +204,8 @@ RUNTIME_FUNCTION(Runtime_SetCode) {

if (isolate->logger()->is_logging_code_events() ||

isolate->cpu_profiler()->is_profiling()) {

- isolate->logger()->LogExistingFunction(source_shared,

- Handle<Code>(source_shared->code()));

+ isolate->logger()->LogExistingFunction(

+ source_shared, Handle<AbstractCode>(source_shared->abstract_code()));

}

return *target;