Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: src/frames.cc

Issue 1728593002: [Interpreter] Add support for cpu profiler logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 50a2e21a055d7a9d8f11442f6cfa024d555c71dc..f8e8c81000b115567d651710eefaaac3f2ec12cf 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -403,6 +403,12 @@ void StackFrame::SetReturnAddressLocationResolver(
return_address_location_resolver_ = resolver;
}
+static bool IsInterpreterFramePc(Isolate* isolate, Address pc) {
+ return (pc >= isolate->interpreter_entry_trampoline_start() &&
+ pc < isolate->interpreter_entry_trampoline_end()) ||
+ (pc >= isolate->interpreter_bytecode_dispatch_start() &&
+ pc < isolate->interpreter_bytecode_dispatch_end());
+}
StackFrame::Type StackFrame::ComputeType(const StackFrameIteratorBase* iterator,
State* state) {
@@ -429,6 +435,9 @@ StackFrame::Type StackFrame::ComputeType(const StackFrameIteratorBase* iterator,
Memory::Object_at(state->fp + StandardFrameConstants::kMarkerOffset);
if (marker->IsSmi()) {
return static_cast<StackFrame::Type>(Smi::cast(marker)->value());
+ } else if (FLAG_ignition && IsInterpreterFramePc(iterator->isolate(),
+ *(state->pc_address))) {
+ return INTERPRETED;
} else {
return JAVA_SCRIPT;
}

Powered by Google App Engine
This is Rietveld 408576698