Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: test/cctest/test-log.cc

Issue 1728593002: [Interpreter] Add support for cpu profiler logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index adbd1a5a373afc79d2de313b32e82543abb17487..c1b7d0f04bb30de602ccbb41ea0a9d609fdddc02 100644
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -553,14 +553,14 @@ TEST(LogVersion) {
TEST(Issue539892) {
class : public i::CodeEventLogger {
public:
- virtual void CodeMoveEvent(Address from, Address to) {}
- virtual void CodeDeleteEvent(Address from) {}
- virtual void CodeDisableOptEvent(i::Code* code,
- i::SharedFunctionInfo* shared) {}
+ void CodeMoveEvent(i::AbstractCode* from, Address to) override {}
+ void CodeDeleteEvent(i::AbstractCode* from) override {}
+ void CodeDisableOptEvent(i::AbstractCode* code,
+ i::SharedFunctionInfo* shared) override {}
private:
- virtual void LogRecordedBuffer(i::Code* code, i::SharedFunctionInfo* shared,
- const char* name, int length) {}
+ void LogRecordedBuffer(i::AbstractCode* code, i::SharedFunctionInfo* shared,
+ const char* name, int length) override {}
} code_event_logger;
SETUP_FLAGS();
v8::Isolate::CreateParams create_params;

Powered by Google App Engine
This is Rietveld 408576698