[Interpreter] Add support for cpu profiler logging.

src/heap/mark-compact.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/mark-compact.h"
 
 #include "src/base/atomicops.h"
 #include "src/base/bits.h"
 #include "src/base/sys-info.h"
 #include "src/code-stubs.h"
@@ skipping 2610 matching lines @@
                                          LocalSlotsBuffer* old_to_new_slots) {
   Address dst_addr = dst->address();
   Address src_addr = src->address();
   DCHECK(heap()->AllowedToBeMigrated(src, dest));
   DCHECK(dest != LO_SPACE);
   if (dest == OLD_SPACE) {
     DCHECK_OBJECT_SIZE(size);
     DCHECK(IsAligned(size, kPointerSize));
 
     heap()->MoveBlock(dst->address(), src->address(), size);
+    if (FLAG_ignition && dst->IsBytecodeArray()) {
+      PROFILE(isolate(), CodeMoveEvent(AbstractCode::cast(src), dst_addr));
+    }
     RecordMigratedSlotVisitor visitor(this, old_to_old_slots, old_to_new_slots);
     dst->IterateBody(&visitor);
   } else if (dest == CODE_SPACE) {
     DCHECK_CODEOBJECT_SIZE(size, heap()->code_space());
-    PROFILE(isolate(), CodeMoveEvent(src_addr, dst_addr));
+    PROFILE(isolate(), CodeMoveEvent(AbstractCode::cast(src), dst_addr));
     heap()->MoveBlock(dst_addr, src_addr, size);
     old_to_old_slots->Record(RELOCATED_CODE_OBJECT, dst_addr);
     Code::cast(dst)->Relocate(dst_addr - src_addr);
   } else {
     DCHECK_OBJECT_SIZE(size);
     DCHECK(old_to_old_slots == nullptr);
     DCHECK(dest == NEW_SPACE);
     heap()->MoveBlock(dst_addr, src_addr, size);
   }
   heap()->OnMoveEvent(dst, src, size);
@@ skipping 1227 matching lines @@
   sweeping_list(heap()->code_space()).clear();
   sweeping_list(heap()->map_space()).clear();
 }
 
 
 // TODO(1466) ReportDeleteIfNeeded is not called currently.
 // Our profiling tools do not expect intersections between
 // code objects. We should either reenable it or change our tools.
 void MarkCompactCollector::ReportDeleteIfNeeded(HeapObject* obj,
                                                 Isolate* isolate) {
-  if (obj->IsCode()) {
-    PROFILE(isolate, CodeDeleteEvent(obj->address()));
+  if (obj->IsCode() && obj->IsBytecodeArray()) {

[ulan, 2016/02/25 11:03:59]

This condition seems to be always false.
Did you mean to add another branch for ByteCodeArrays here?
Or IsAbstractCode check?

[rmcilroy, 2016/02/25 11:46:54]

Opps, this should indeed be an '||', updated. This didn't cause any issue
because this is dead code (see comment above), maybe we should just delete this
whole function and the associated CodeDeleteEvent?

[Yang, 2016/02/25 11:50:43]

+1

[ulan, 2016/02/25 12:07:50]

I would be fine with deleting the dead code.

[rmcilroy, 2016/02/25 15:06:54]

Dead code removed.

+    PROFILE(isolate, CodeDeleteEvent(AbstractCode::cast(obj)));
   }
 }
 
 
 Isolate* MarkCompactCollector::isolate() const { return heap_->isolate(); }
 
 
 void MarkCompactCollector::Initialize() {
   MarkCompactMarkingVisitor::Initialize();
   IncrementalMarking::Initialize();
@@ skipping 19 matching lines @@
     MarkBit mark_bit = Marking::MarkBitFrom(host);
     if (Marking::IsBlack(mark_bit)) {
       RelocInfo rinfo(isolate(), pc, RelocInfo::CODE_TARGET, 0, host);
       RecordRelocSlot(host, &rinfo, target);
     }
   }
 }
 
 }  // namespace internal
 }  // namespace v8