Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: content/browser/download/download_request_handle.h

Issue 1728583002: Simplify DownloadRequestHandle by using WebContentsGetter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_request_handle.h
diff --git a/content/browser/download/download_request_handle.h b/content/browser/download/download_request_handle.h
index 5d047c759100235176678230085abb6717e989e2..11723ad018d3a0059bf8159aed1e8ef1802e43ae 100644
--- a/content/browser/download/download_request_handle.h
+++ b/content/browser/download/download_request_handle.h
@@ -11,6 +11,7 @@
#include "base/memory/weak_ptr.h"
#include "content/browser/download/download_resource_handler.h"
#include "content/common/content_export.h"
+#include "content/public/browser/resource_request_info.h"
namespace content {
class DownloadManager;
@@ -56,12 +57,9 @@ class CONTENT_EXPORT DownloadRequestHandle
// allowing mocking of ResourceDispatcherHost in unit tests.
DownloadRequestHandle();
- // Note that |rdh| is required to be non-null.
DownloadRequestHandle(const base::WeakPtr<DownloadResourceHandler>& handler,
- int child_id,
- int render_view_id,
- int request_id,
- int frame_tree_node_id);
+ const content::ResourceRequestInfo::WebContentsGetter&
+ web_contents_getter);
// Implement DownloadRequestHandleInterface interface.
WebContents* GetWebContents() const override;
@@ -73,19 +71,7 @@ class CONTENT_EXPORT DownloadRequestHandle
private:
base::WeakPtr<DownloadResourceHandler> handler_;
-
- // The ID of the child process that started the download.
- int child_id_;
-
- // The ID of the render view that started the download.
- int render_view_id_;
-
- // The ID associated with the request used for the download.
- int request_id_;
-
- // PlzNavigate
- // The ID of the FrameTreeNode that started the download.
- int frame_tree_node_id_;
+ content::ResourceRequestInfo::WebContentsGetter web_contents_getter_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698