|
|
DescriptionUse new API instead of the deprecated ones.
This change will allow us to remove the old API in follow up clean up.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728553002
Committed: https://skia.googlesource.com/skia/+/2d172ebb29d7afe47aa179211c9f92187f28ec52
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (7 generated)
Description was changed from ========== Use new API instead of the deprecated ones BUG=skia: ========== to ========== Use new API instead of the deprecated ones BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Use new API instead of the deprecated ones BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Use new API instead of the deprecated ones. This change will allow us to remove the old API in follow up clean up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
yujieqin@google.com changed reviewers: + msarett@google.com, scroggo@google.com
The CQ bit was checked by yujieqin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728553002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-02-23 20:23 UTC
lgtm
The CQ bit was unchecked by yujieqin@google.com
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728553002/1
Message was sent while issue was closed.
Description was changed from ========== Use new API instead of the deprecated ones. This change will allow us to remove the old API in follow up clean up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Use new API instead of the deprecated ones. This change will allow us to remove the old API in follow up clean up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/2d172ebb29d7afe47aa179211c9f92187f28ec52 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2d172ebb29d7afe47aa179211c9f92187f28ec52
Message was sent while issue was closed.
https://codereview.chromium.org/1728553002/diff/1/src/codec/SkRawCodec.cpp File src/codec/SkRawCodec.cpp (right): https://codereview.chromium.org/1728553002/diff/1/src/codec/SkRawCodec.cpp#ne... src/codec/SkRawCodec.cpp:575: if (error == ::piex::Error::kOk && imageData.preview.length > 0) { Unfortunately, this will mean that we need to update piex in nyc-dev in order to merge Skia into master. The way we typically handle this is is with macros. Something like: #ifdef SK_LEGACY_PREVIEW_LENGTH if (error == ::piex::Error::kOk && imageData.preview_length > 0) { #else if (error == ::piex::Error::kOk && imageData.preview.length > 0) { #endif We can define SK_LEGACY_PREVIEW_LENGTH in Android until piex gets updated to have the new API. Then we can delete the old code in Skia and then delete the old API in piex.
Message was sent while issue was closed.
It should be fine now, the PIEX is merged.
Message was sent while issue was closed.
On 2016/02/23 16:26:31, yujieqin wrote: > It should be fine now, the PIEX is merged. Great, thanks! |