Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1728553002: Use new API instead of the deprecated ones (Closed)

Created:
4 years, 10 months ago by yujieqin
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, adaubert, ebrauer
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use new API instead of the deprecated ones. This change will allow us to remove the old API in follow up clean up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728553002 Committed: https://skia.googlesource.com/skia/+/2d172ebb29d7afe47aa179211c9f92187f28ec52

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/codec/SkRawCodec.cpp View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 16 (7 generated)
yujieqin
4 years, 10 months ago (2016-02-23 14:23:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728553002/1
4 years, 10 months ago (2016-02-23 14:23:42 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-23 14:23:43 UTC) #7
msarett
lgtm
4 years, 10 months ago (2016-02-23 14:40:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728553002/1
4 years, 10 months ago (2016-02-23 14:42:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2d172ebb29d7afe47aa179211c9f92187f28ec52
4 years, 10 months ago (2016-02-23 14:49:41 UTC) #13
scroggo
https://codereview.chromium.org/1728553002/diff/1/src/codec/SkRawCodec.cpp File src/codec/SkRawCodec.cpp (right): https://codereview.chromium.org/1728553002/diff/1/src/codec/SkRawCodec.cpp#newcode575 src/codec/SkRawCodec.cpp:575: if (error == ::piex::Error::kOk && imageData.preview.length > 0) { ...
4 years, 10 months ago (2016-02-23 15:55:23 UTC) #14
yujieqin
It should be fine now, the PIEX is merged.
4 years, 10 months ago (2016-02-23 16:26:31 UTC) #15
scroggo
4 years, 10 months ago (2016-02-23 16:51:29 UTC) #16
Message was sent while issue was closed.
On 2016/02/23 16:26:31, yujieqin wrote:
> It should be fine now, the PIEX is merged.

Great, thanks!

Powered by Google App Engine
This is Rietveld 408576698