Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: sandbox/win/src/sharedmem_ipc_client.cc

Issue 172853002: Fix a compilation issue when building with VS2013 and optimization set to "max". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finally after a lot of "Upload got a 500 response: 500" Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/sharedmem_ipc_client.cc
diff --git a/sandbox/win/src/sharedmem_ipc_client.cc b/sandbox/win/src/sharedmem_ipc_client.cc
index a9eb01f36b27003248fc13b1fe2b0f795dfc88cd..9d37bbda7d406cc8fb9ffc3b36a88ccc6999adca 100644
--- a/sandbox/win/src/sharedmem_ipc_client.cc
+++ b/sandbox/win/src/sharedmem_ipc_client.cc
@@ -31,7 +31,7 @@ void SharedMemIPCClient::FreeBuffer(void* buffer) {
size_t num = ChannelIndexFromBuffer(buffer);
ChannelControl* channel = control_->channels;
LONG result = ::InterlockedExchange(&channel[num].state, kFreeChannel);
- DCHECK(kFreeChannel != result);
+ DCHECK_NE(kFreeChannel, static_cast<ChannelState>(result));
result;
}
@@ -145,7 +145,7 @@ size_t SharedMemIPCClient::LockFreeChannel(bool* severe_failure) {
size_t SharedMemIPCClient::ChannelIndexFromBuffer(const void* buffer) {
ptrdiff_t d = reinterpret_cast<const char*>(buffer) - first_base_;
size_t num = d/kIPCChannelSize;
- DCHECK(num < control_->channels_count);
+ DCHECK_LT(num, control_->channels_count);
return (num);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698