Issue 17285002: ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17285002: ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows. (Closed)

Created:
7 years, 6 months ago by alexeypa (please no reviews)

Modified:
7 years, 6 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows.

Patch Set 2 : CR feedback. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -62 lines)			Patch
	M	ui/base/clipboard/clipboard.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	ui/base/clipboard/clipboard_win.cc	View	1	7 chunks	+84 lines, -58 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

https://codereview.chromium.org/17285002/diff/1/ui/base/clipboard/clipboard_win.cc File ui/base/clipboard/clipboard_win.cc (right): https://codereview.chromium.org/17285002/diff/1/ui/base/clipboard/clipboard_win.cc#newcode157 ui/base/clipboard/clipboard_win.cc:157: scoped_ptr<base::win::MessageWindow> window_; why scoped_ptr?

7 years, 6 months ago (2013-06-19 00:11:36 UTC) #1

alexeypa (please no reviews)

7 years, 6 months ago (2013-06-19 17:57:18 UTC) #2

https://codereview.chromium.org/17285002/diff/1/ui/base/clipboard/clipboard_w...
File ui/base/clipboard/clipboard_win.cc (right):

https://codereview.chromium.org/17285002/diff/1/ui/base/clipboard/clipboard_w...
ui/base/clipboard/clipboard_win.cc:157: scoped_ptr<base::win::MessageWindow>
window_;
On 2013/06/19 00:11:36, cpu wrote:
> why scoped_ptr?

Yes, indeed. It does not need to be.

Expand Messages | Collapse Messages

Issue 17285002: ui::Clipboard now uses base::win::MessageWindow to create a message-only window on Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : CR feedback. #

Messages