Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: content/public/renderer/BUILD.gn

Issue 1728453002: Enable H.264 video WebRTC behind run-time flag and add WebRtcBrowserTest for H.264 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: #define macro instead of BUILDFLAG. common_features (aka renderer_features) deleted. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/feature_h264_with_openh264_ffmpeg.cc ('k') | content/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/BUILD.gn
diff --git a/content/public/renderer/BUILD.gn b/content/public/renderer/BUILD.gn
index 719eadf6771980e13dd3748f7c48c017414328ae..a169d0376754197685354f0d6826f9b317721e67 100644
--- a/content/public/renderer/BUILD.gn
+++ b/content/public/renderer/BUILD.gn
@@ -4,6 +4,7 @@
import("//build/config/features.gni")
import("//content/renderer/renderer.gni")
+import("//third_party/webrtc/build/webrtc.gni")
# See //content/BUILD.gn for how this works.
group("renderer") {
@@ -37,6 +38,7 @@ source_set("renderer_sources") {
"//ui/gfx",
"//v8",
]
+ defines = []
allow_circular_includes_from = [
# This target is a pair with content/renderer. They always go together and
@@ -49,7 +51,13 @@ source_set("renderer_sources") {
rebase_path(content_renderer_gypi_values.public_renderer_webrtc_sources,
".",
"//content")
- deps += [ "//third_party/webrtc" ]
+ deps += [
+ "//content/public/common:feature_h264_with_openh264_ffmpeg",
+ "//third_party/webrtc",
+ ]
+ if (rtc_use_h264) {
+ defines += [ "BUILDFLAG_RTC_USE_H264" ]
+ }
}
if (enable_plugins) {
« no previous file with comments | « content/public/common/feature_h264_with_openh264_ffmpeg.cc ('k') | content/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698