Issue 172843002: The cricket::VideoCapturer on longer makes a copy of the frame from the camera. As a result we can'…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172843002: The cricket::VideoCapturer on longer makes a copy of the frame from the camera. As a result we can'… (Closed)

Created:
6 years, 10 months ago by Ronghua Wu (Left Chromium)

Modified:
6 years, 10 months ago

Reviewers:
perkj_chrome, wjia(left Chromium)

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

The cricket::VideoCapturer no longer makes a copy of the frame from the camera. As a result we can't just do a shallow copy as the underlying buffer maybe invalid after the function returns. Instead we now have to make a copy in video_source_handler before return. TEST=updated unit test BUG=344957 R=perkj@chromium.org, wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252129

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -16 lines)			Patch
	M	content/renderer/media/video_source_handler.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	content/renderer/media/video_source_handler_unittest.cc	View		2 chunks	+45 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ronghua Wu (Left Chromium)

6 years, 10 months ago (2014-02-20 00:02:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r252129 (presubmit successful).

Expand Messages | Collapse Messages