Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/fetch/MockResourceClients.h

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and reflect comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/MockResourceClients.h
diff --git a/third_party/WebKit/Source/core/fetch/MockResourceClients.h b/third_party/WebKit/Source/core/fetch/MockResourceClients.h
index 6fa5351f9865df3f7db99fe3a981ece75975a3f0..4a0b247774b7c7aab51b613031ef49136ac4bdbb 100644
--- a/third_party/WebKit/Source/core/fetch/MockResourceClients.h
+++ b/third_party/WebKit/Source/core/fetch/MockResourceClients.h
@@ -45,8 +45,8 @@ public:
void notifyFinished(Resource*) override;
String debugName() const override { return "MockResourceClient"; }
- bool notifyFinishedCalled() const { return m_notifyFinishedCalled; }
+ virtual bool notifyFinishedCalled() const { return m_notifyFinishedCalled; }
virtual void removeAsClient();
protected:
@@ -60,16 +60,19 @@ public:
explicit MockImageResourceClient(const PassRefPtrWillBeRawPtr<ImageResource>);
~MockImageResourceClient() override;
- void imageChanged(ImageResource*, const IntRect*) override;
+ void imageChanged(bool isNotifyingFinish, ImageResource*, const IntRect*) override;
String debugName() const override { return "MockImageResourceClient"; }
+ bool notifyFinishedCalled() const override;
+
void removeAsClient() override;
int imageChangedCount() const { return m_imageChangedCount; }
private:
int m_imageChangedCount;
+ int m_imageChangedNotifyingFinishCount;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698