third_party/WebKit/Source/core/fetch/ImageResourceObserver.h - Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit refine. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/MockResourceClients.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h b/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

index 9a002c477c12100c035465e2c87e7df94b32d336..9c54358fe928e5af805c63b4253415d087075cea 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

+++ b/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

@@ -39,7 +39,7 @@ public:

// Called whenever a frame of an image changes, either because we got more data from the network or

// because we are animating. If not null, the IntRect is the changed rect of the image.

yhirano 2016/03/02 01:20:34 Please add some comments about isNotifyingFinish.

hiroshige 2016/03/12 01:04:49 Done.

- virtual void imageChanged(ImageResource*, const IntRect* = 0) { }

+ virtual void imageChanged(bool isNotifyingFinish, ImageResource*, const IntRect* = 0) { }

// Called to find out if this client wants to actually display the image. Used to tell when we

// can halt animation. Content nodes that hold image refs for example would not render the image,