Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2]

third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
@@ skipping 21 matching lines @@
 
 class ImageResource;
 class IntRect;
 
 class CORE_EXPORT ImageResourceObserver {
 public:
     virtual ~ImageResourceObserver() {}
 
     // Called whenever a frame of an image changes, either because we got more data from the network or
     // because we are animating. If not null, the IntRect is the changed rect of the image.
-    virtual void imageChanged(ImageResource*, const IntRect* = 0) { }
+    // imageChanged() is called with |isNotifyingFinish| = true exactly once
+    // around when ResourceClient::notifyFinished() would be called, and in
+    // the other cases |isNotifyingFinish| is false.
+    virtual void imageChanged(bool isNotifyingFinish, ImageResource*, const IntRect* = 0) { }

[esprehn, 2016/03/22 23:31:49]

I think I'd rather two different callbacks for the finished and non finished
cases.

[hiroshige, 2016/03/24 17:26:44]

Done. I added notifyFinished() here also, and revert imageChanged() changes.

 
     // Called to find out if this client wants to actually display the image. Used to tell when we
     // can halt animation. Content nodes that hold image refs for example would not render the image,
     // but LayoutImages would (assuming they have visibility: visible and their layout tree isn't hidden
     // e.g., in the b/f cache or in a background tab).
     virtual bool willRenderImage() { return false; }
 
     // Called to get imageAnimation policy from settings
     virtual bool getImageAnimationPolicy(ImageAnimationPolicy&) { return false; }
 
     virtual ResourcePriority computeResourcePriority() const { return ResourcePriority(); }
 
     // Name for debugging, e.g. shown in memory-infra.
     virtual String debugName() const = 0;
 
     static bool isExpectedType(ImageResourceObserver*) { return true; }
 };
 
 } // namespace blink
 
 #endif