tools/gn: Add out-of-line copy ctors for complex classes.

tools/gn: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=brettw@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/7d50ff54f4c5fd2a1a4cf52a919f9eb15d5d5469
Cr-Commit-Position: refs/heads/master@{#377375}

[vmpstr, 2016-02-24 18:59:56]

Please take a look.

[brettw, 2016-02-24 19:06:00]

lgtm, thanks!

[tfarina, 2016-02-24 19:13:48]

So is this different from DISALLOW_COPY macro? Sorry for my ignorance in C++11
here.

https://chromium.googlesource.com/chromium/src/+/master/base/macros.h#17

https://codereview.chromium.org/1728303003/diff/1/tools/gn/label.h
File tools/gn/label.h (right):

https://codereview.chromium.org/1728303003/diff/1/tools/gn/label.h#newcode32
tools/gn/label.h:32: Label(const Label& other);
add empty lines before and after like in Err?

[tfarina, 2016-02-24 19:15:11]

Actually, in those cases the classes are copyable? Hence the default rather than
delete?

[brettw, 2016-02-24 19:17:25]

I think I intended these classes to be copyable.

[vmpstr, 2016-02-24 19:30:28]

Yeah these classes are being copied. The clang plugin to detect these cases saw
that there was an implicit copy ctor, which would only be generated if something
did copy it.

[vmpstr, 2016-02-24 19:30:37]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-02-24 19:35:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1728303003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1728303003/1

[tfarina, 2016-02-24 19:52:08]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2016-02-24 19:52:09]

Thanks.

lgtm

[commit-bot: I haz the power, 2016-02-24 20:45:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-24 20:46:14]

Description was changed from

==========
tools/gn: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=brettw@chromium.org, dcheng@chromium.org, thakis@chromium.org
==========

to

==========
tools/gn: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=brettw@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/7d50ff54f4c5fd2a1a4cf52a919f9eb15d5d5469
Cr-Commit-Position: refs/heads/master@{#377375}
==========

[commit-bot: I haz the power, 2016-02-24 20:46:15]

Patchset 1 (id:??) landed as
https://crrev.com/7d50ff54f4c5fd2a1a4cf52a919f9eb15d5d5469
Cr-Commit-Position: refs/heads/master@{#377375}