Issue 17283007: Directly use C++ builtin of ArrayPush for String.prototype.split.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17283007: Directly use C++ builtin of ArrayPush for String.prototype.split. (Closed)

Created:
7 years, 6 months ago by Yang

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Directly use C++ builtin of ArrayPush for String.prototype.split. R=svenpanne@chromium.org BUG=v8:2737 Committed: https://code.google.com/p/v8/source/detail?r=15223

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	src/string.js	View		4 chunks	+13 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. Just for the record: I tried a different approach, still using the InternalArray, but ...

7 years, 6 months ago (2013-06-20 08:02:06 UTC) #2

Yang

7 years, 6 months ago (2013-06-20 08:13:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15223 (presubmit successful).