Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1728283003: Add 4f linear gradient benches (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -52 lines) Patch
M bench/GradientBench.cpp View 11 chunks +81 lines, -52 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
f(malita)
Current numbers (nanobench -m gradient_linear --config 8888 --samples 1000 -q): 198.61 gradient_linear_mirror 86.38 gradient_linear_mirror_4f 198.49 ...
4 years, 10 months ago (2016-02-24 20:31:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728283003/1
4 years, 10 months ago (2016-02-24 20:33:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 20:44:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728283003/1
4 years, 10 months ago (2016-02-24 22:22:36 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-24 22:22:37 UTC) #9
mtklein
lgtm
4 years, 10 months ago (2016-02-24 23:32:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/36693b5ac850257483643586d6cdb83defa90d9c
4 years, 10 months ago (2016-02-24 23:33:01 UTC) #12
mtklein
(I will happily serve as TBR= target for CLs like this if waiting for a ...
4 years, 10 months ago (2016-02-24 23:33:38 UTC) #13
f(malita)
4 years, 10 months ago (2016-02-25 00:19:09 UTC) #14
Message was sent while issue was closed.
On 2016/02/24 23:33:38, mtklein wrote:
> (I will happily serve as TBR= target for CLs like this if waiting for a review
> even vaguely inconveniences you.)

Thanks, I would totally cowboy-land if in a hurry.

Exhibit A: TBR, NOTRY and all bots red
https://codereview.chromium.org/1733833002 (just don't let any chromium sheriff
see that :)

Powered by Google App Engine
This is Rietveld 408576698