Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 1728253003: Make NodeIterator more STL-friendly. (Closed)

Created:
4 years, 10 months ago by Alexander Semashko
Modified:
4 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NodeIterator more STL-friendly. This allows it to be used in various algorithms. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/49ed0e3a1623c8524d4eae827da2ae37bfba06dc Cr-Commit-Position: refs/heads/master@{#381807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/frame_host/frame_tree.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 27 (8 generated)
Alexander Semashko
4 years, 10 months ago (2016-02-24 15:09:14 UTC) #3
Alexander Semashko
PTAL
4 years, 9 months ago (2016-03-01 19:38:19 UTC) #4
clamy
@dcheng: could you PTAL since you introduced the iterator in the ifrst place?
4 years, 9 months ago (2016-03-14 13:36:00 UTC) #6
dcheng
Is there a use case where this would come in handy?
4 years, 9 months ago (2016-03-14 20:28:18 UTC) #7
Alexander Semashko
On 2016/03/14 20:28:18, dcheng wrote: > Is there a use case where this would come ...
4 years, 9 months ago (2016-03-14 21:45:46 UTC) #8
dcheng
I don't think we'd actually want to rewrite things like FrameTree::IsLoading(). Instead of looking like ...
4 years, 9 months ago (2016-03-14 23:11:18 UTC) #9
Alexander Semashko
On 2016/03/14 23:11:18, dcheng wrote: > I don't think we'd actually want to rewrite things ...
4 years, 9 months ago (2016-03-14 23:34:05 UTC) #10
dcheng
On 2016/03/14 at 23:34:05, ahest wrote: > On 2016/03/14 23:11:18, dcheng wrote: > > I ...
4 years, 9 months ago (2016-03-14 23:35:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728253003/1
4 years, 9 months ago (2016-03-14 23:41:58 UTC) #14
Alexander Semashko
On 2016/03/14 23:35:51, dcheng wrote: > On 2016/03/14 at 23:34:05, ahest wrote: > > On ...
4 years, 9 months ago (2016-03-14 23:45:17 UTC) #15
dcheng
On 2016/03/14 at 23:45:17, ahest wrote: > On 2016/03/14 23:35:51, dcheng wrote: > > On ...
4 years, 9 months ago (2016-03-14 23:48:29 UTC) #16
Alexander Semashko
On 2016/03/14 23:48:29, dcheng wrote: > On 2016/03/14 at 23:45:17, ahest wrote: > > On ...
4 years, 9 months ago (2016-03-14 23:52:00 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/156963)
4 years, 9 months ago (2016-03-14 23:53:14 UTC) #19
ncarter (slow)
Link to ConstNodeRange removal CL: where https://codereview.chromium.org/1802163002/
4 years, 9 months ago (2016-03-16 21:54:09 UTC) #20
Alexander Semashko
Nick, WDYT about this CL? It is still missing an owner's lgtm.
4 years, 9 months ago (2016-03-17 13:58:03 UTC) #21
ncarter (slow)
lgtm
4 years, 9 months ago (2016-03-17 20:45:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728253003/1
4 years, 9 months ago (2016-03-17 20:46:07 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 22:23:59 UTC) #25
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:25:19 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49ed0e3a1623c8524d4eae827da2ae37bfba06dc
Cr-Commit-Position: refs/heads/master@{#381807}

Powered by Google App Engine
This is Rietveld 408576698