Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1728193003: Revert of Encode interpreter::SourcePositionTable as variable-length ints. (Closed)

Created:
4 years, 10 months ago by vogelheim
Modified:
4 years, 10 months ago
CC:
Hannes Payer (out of office), oth, ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Encode interpreter::SourcePositionTable as variable-length ints. (patchset #10 id:200001 of https://codereview.chromium.org/1704943002/ ) Reason for revert: Build failure on Linux64 arm64 ASAN: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN%20arm64%20-%20debug%20builder/builds/4829 (Leaks memory, somehow.) Original issue's description: > Encode interpreter::SourcePositionTable as variable-length ints. > > This reduces the memory consumption of SourcePositionTable by ca. 2/3. > Over Octane, this reduces the source position table memory consumption > from ~370kB to ~115kB, which makes it ca. 10% of the total bytecode size > (~1.1MB) > > BUG= > > Committed: https://crrev.com/a6f41f7b8226555c5900440f6e3092b3545ee0f6 > Cr-Commit-Position: refs/heads/master@{#34250} TBR=jochen@chromium.org,rmcilroy@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b38eabe8454b1b78e6876feec2b05a09476f29fd Cr-Commit-Position: refs/heads/master@{#34251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -279 lines) Patch
M src/debug/debug.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M src/interpreter/source-position-table.h View 1 chunk +26 lines, -34 lines 0 comments Download
M src/interpreter/source-position-table.cc View 2 chunks +46 lines, -150 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
D test/unittests/interpreter/source-position-table-unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vogelheim
Created Revert of Encode interpreter::SourcePositionTable as variable-length ints.
4 years, 10 months ago (2016-02-24 13:31:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728193003/1
4 years, 10 months ago (2016-02-24 13:31:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728193003/1
4 years, 10 months ago (2016-02-24 13:31:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 13:32:13 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:33:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b38eabe8454b1b78e6876feec2b05a09476f29fd
Cr-Commit-Position: refs/heads/master@{#34251}

Powered by Google App Engine
This is Rietveld 408576698