Support dragging texts into Android WebView.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 590 matching lines @@
 
 #if defined(OS_CHROMEOS)
   // The externalfile:// scheme is used in Chrome OS to open external files in a
   // browser tab.
   if (drop_data.url.SchemeIs(content::kExternalFileScheme))
     policy->GrantRequestURL(renderer_id, drop_data.url);
 #endif
 
   // The URL could have been cobbled together from any highlighted text string,
   // and can't be interpreted as a capability.
   DropData filtered_data(drop_data);

[aelias_OOO_until_Jul13, 2016/03/01 19:57:32]

There's a lot of code here to filter the DropData that you aren't running.  It
has to do with file:// URLs which I realize we probably don't care much about,
but for consistency's sake, could you also run this same code on your later
DropData?

[hush (inactive), 2016/03/01 23:54:19]

Yes. I just did it with the latest patch.

   GetProcess()->FilterURL(true, &filtered_data.url);
   if (drop_data.did_originate_from_renderer) {
     filtered_data.filenames.clear();
   }
 
   // The filenames vector, on the other hand, does represent a capability to
   // access the given files.
   storage::IsolatedContext::FileInfoSet files;
   for (std::vector<ui::FileInfo>::iterator iter(
            filtered_data.filenames.begin());
@@ skipping 80 matching lines @@
 
 void RenderViewHostImpl::DragTargetDragLeave() {
   Send(new DragMsg_TargetDragLeave(GetRoutingID()));
 }
 
 void RenderViewHostImpl::DragTargetDrop(
     const gfx::Point& client_pt,
     const gfx::Point& screen_pt,
     int key_modifiers) {
   const gfx::Point client_pt_in_viewport = ConvertDIPToViewport(client_pt);
   Send(new DragMsg_TargetDrop(GetRoutingID(), client_pt_in_viewport, screen_pt,

[aelias_OOO_until_Jul13, 2016/03/01 19:57:32]

I'd propose modifying this existing message to take a WebDropData instead.  For
non-Android a DropData object with "m_valid = false" can be sent down that can
be ignored on the receiving end.

[hush (inactive), 2016/03/01 23:54:19]

I updated the other CL to change the existing DragTargetDrop IPC to include a
content::DropData and a boolean (which indicates if the dropdata is valid). The
reason why I am sending content::DropData instead of blink::WebDragData is for
consistency:
Between browser and renderer, we always send content::DropData, in
TargetDragEnter,TargetDrop and StartDragging (from renderer to browser).

                               key_modifiers));
 }
 
+#if defined(OS_ANDROID)

[aelias_OOO_until_Jul13, 2016/03/01 19:57:32]

Could you remove all "#if defined(OS_ANDROID)" from this patch and also from
https://codereview.chromium.org/1723763002 ?  Just because a codepath happens to
currently be run on Android is not a sufficient reason to have them in my mind. 
They make a lot of things annoying: testing, trybots, code sharing, etc.

[hush (inactive), 2016/03/01 23:54:19]

I merged the new IPC into the existing IPC

+void RenderViewHostImpl::DragTargetDropWithData(const DropData& drop_data,
+                                                const gfx::Point& client_pt,
+                                                const gfx::Point& screen_pt,
+                                                int key_modifiers) {
+  // TODO(hush): filter the drop_data when we start to support dragging files.
+  const gfx::Point client_pt_in_viewport = ConvertDIPToViewport(client_pt);
+  Send(new DragMsg_TargetDropWithData(GetRoutingID(), drop_data,
+                                      client_pt_in_viewport, screen_pt,
+                                      key_modifiers));
+}
+#endif
+
 void RenderViewHostImpl::DragSourceEndedAt(
     int client_x, int client_y, int screen_x, int screen_y,
     WebDragOperation operation) {
   const gfx::Point client_pt_in_viewport =
       ConvertDIPToViewport(gfx::Point(client_x, client_y));
   Send(new DragMsg_SourceEnded(GetRoutingID(), client_pt_in_viewport,
                                gfx::Point(screen_x, screen_y), operation));
 }
 
 void RenderViewHostImpl::DragSourceSystemDragEnded() {
@@ skipping 644 matching lines @@
 
 gfx::Point RenderViewHostImpl::ConvertDIPToViewport(const gfx::Point& point) {
   // The point in guest view is already converted.
   if (!render_widget_host_->scale_input_to_viewport())
     return point;
   float scale = GetWidget()->GetView()->current_device_scale_factor();
   return gfx::Point(point.x() * scale, point.y() * scale);
 }
 
 }  // namespace content