Support dragging texts into Android WebView.

content/public/browser/render_view_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_
 
 #include "base/callback_forward.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
@@ skipping 127 matching lines @@
       int key_modifiers) = 0;
   virtual void DragTargetDragOver(
       const gfx::Point& client_pt,
       const gfx::Point& screen_pt,
       blink::WebDragOperationsMask operations_allowed,
       int key_modifiers) = 0;
   virtual void DragTargetDragLeave() = 0;
   virtual void DragTargetDrop(const gfx::Point& client_pt,
                               const gfx::Point& screen_pt,
                               int key_modifiers) = 0;
+#if defined(OS_ANDROID)
+  virtual void DragTargetDropWithData(const DropData& drop_data,

[aelias_OOO_until_Jul13, 2016/02/25 20:58:00]

Why do you need to add a new platform-specific method?  This has close to the
same arguments to DragTargetDragEnter, what is the meaning/value-added of this
new method?

[hush (inactive), 2016/02/27 01:46:13]

See CL: https://codereview.chromium.org/1723763002/
On Android, we don't have the text being dragged until ACTION_DROP. So the
DropData that's passed during DragTargetDragEnter does not contain the real text
being dragged. We have to pass another DropData during ACTION_DROP, and that's
what this function does.
On other platforms (aura), we have access to the dragged when the drag starts,
so there is no need to specify the drop data again during 'drop' action.

[aelias_OOO_until_Jul13, 2016/02/27 01:54:41]

It doesn't seem great that we're passing in fake/empty data in
DragTargetDragEnter, that seems misleading.  Can you remove the DropData from
DragTargetDragEnter and refactor all platforms to use your new DropData IPC?

[hush (inactive), 2016/02/29 18:27:41]

I can do that. But this would bloat this CL significantly though. I would do it
in another CL that sits between https://codereview.chromium.org/1723763002/ and
this CL.

[hush (inactive), 2016/03/01 18:54:28]

Hi Alex, 
I did some investigation yesterday and it turns out I can't remove the dropdata
from DragEnter on all platforms as that would break the drag and drop spec. 
https://www.w3.org/TR/2010/WD-html5-20101019/dnd.html#the-dragevent-and-datat...

Javascript API requires that "dataTransfer" object which contains the dragged
data is available when the drag starts, and when it updates its location. 

That is to say, Android's drag and drop is breaking the HTML spec inevitably. We
might just have to live with that, passing an empty dummy data when the drag
starts. At least we're indicating what the type of the data is. 

We could ask Android to make the data available when the drag starts (if it is
possible), but that's for another Android release.

+                                      const gfx::Point& client_pt,
+                                      const gfx::Point& screen_pt,
+                                      int key_modifiers) = 0;
+#endif
 
   // Instructs the RenderView to automatically resize and send back updates
   // for the new size.
   virtual void EnableAutoResize(const gfx::Size& min_size,
                                 const gfx::Size& max_size) = 0;
 
   // Turns off auto-resize and gives a new size that the view should be.
   virtual void DisableAutoResize(const gfx::Size& new_size) = 0;
 
   // Instructs the RenderView to send back updates to the preferred size.
@@ skipping 60 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderViewHostImpl;
   RenderViewHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_