Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: device/bluetooth/bluetooth_low_energy_win.cc

Issue 1728163006: Implement BluetoothRemoteGattCharacteristicWin::GetDescriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_low_energy_win.h ('k') | device/bluetooth/bluetooth_low_energy_win_fake.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_low_energy_win.cc
diff --git a/device/bluetooth/bluetooth_low_energy_win.cc b/device/bluetooth/bluetooth_low_energy_win.cc
index 1e985b54f1b00b2b771c61374519a5c76a19490b..4d885658da2678a402898d566c1a13300baf365a 100644
--- a/device/bluetooth/bluetooth_low_energy_win.cc
+++ b/device/bluetooth/bluetooth_low_energy_win.cc
@@ -728,27 +728,25 @@ HRESULT BluetoothLowEnergyWrapper::ReadCharacteristicsOfAService(
if (!file.IsValid())
return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
- USHORT required_length = 0;
+ USHORT allocated_length = 0;
HRESULT hr = BluetoothGATTGetCharacteristics(file.GetPlatformFile(), service,
- 0, NULL, &required_length,
+ 0, NULL, &allocated_length,
BLUETOOTH_GATT_FLAG_NONE);
if (hr != HRESULT_FROM_WIN32(ERROR_MORE_DATA))
return hr;
out_included_characteristics->reset(
- new BTH_LE_GATT_CHARACTERISTIC[required_length]);
- USHORT actual_length = required_length;
- hr = BluetoothGATTGetCharacteristics(
- file.GetPlatformFile(), service, actual_length,
- out_included_characteristics->get(), &required_length,
- BLUETOOTH_GATT_FLAG_NONE);
- if (SUCCEEDED(hr) && required_length != actual_length) {
+ new BTH_LE_GATT_CHARACTERISTIC[allocated_length]);
+ hr = BluetoothGATTGetCharacteristics(file.GetPlatformFile(), service,
+ allocated_length,
+ out_included_characteristics->get(),
+ out_counts, BLUETOOTH_GATT_FLAG_NONE);
+ if (SUCCEEDED(hr) && allocated_length != *out_counts) {
LOG(ERROR) << "Retrieved charactersitics is not equal to expected"
- << " actual_length " << actual_length << " required_length "
- << required_length;
+ << " allocated_length " << allocated_length << " got "
+ << *out_counts;
hr = HRESULT_FROM_WIN32(ERROR_INVALID_USER_BUFFER);
}
- *out_counts = actual_length;
if (FAILED(hr)) {
out_included_characteristics->reset(nullptr);
@@ -757,5 +755,39 @@ HRESULT BluetoothLowEnergyWrapper::ReadCharacteristicsOfAService(
return hr;
}
+HRESULT BluetoothLowEnergyWrapper::ReadDescriptorsOfACharacteristic(
+ base::FilePath& service_path,
+ const PBTH_LE_GATT_CHARACTERISTIC characteristic,
+ scoped_ptr<BTH_LE_GATT_DESCRIPTOR>* out_included_descriptors,
+ USHORT* out_counts) {
+ base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ);
+ if (!file.IsValid())
+ return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
+
+ USHORT allocated_length = 0;
+ HRESULT hr = BluetoothGATTGetDescriptors(
+ file.GetPlatformFile(), characteristic, 0, NULL, &allocated_length,
+ BLUETOOTH_GATT_FLAG_NONE);
+ if (hr != HRESULT_FROM_WIN32(ERROR_MORE_DATA))
+ return hr;
+
+ out_included_descriptors->reset(new BTH_LE_GATT_DESCRIPTOR[allocated_length]);
+ hr = BluetoothGATTGetDescriptors(
+ file.GetPlatformFile(), characteristic, allocated_length,
+ out_included_descriptors->get(), out_counts, BLUETOOTH_GATT_FLAG_NONE);
+ if (SUCCEEDED(hr) && allocated_length != *out_counts) {
+ LOG(ERROR) << "Retrieved descriptors is not equal to expected"
+ << " allocated_length " << allocated_length << " got "
+ << *out_counts;
+ hr = HRESULT_FROM_WIN32(ERROR_INVALID_USER_BUFFER);
+ }
+
+ if (FAILED(hr)) {
+ out_included_descriptors->reset(nullptr);
+ *out_counts = 0;
+ }
+ return hr;
+}
+
} // namespace win
} // namespace device
« no previous file with comments | « device/bluetooth/bluetooth_low_energy_win.h ('k') | device/bluetooth/bluetooth_low_energy_win_fake.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698