Allow some fields to be overridden in strong mode.

Allow some fields to be overridden in strong mode.

For consistency, any field in a class that's meant to be extended can be
overridden.

R=lrn@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/source_span/commit/38273257d0bd61afd315ae7abaccce603dc362e4

[Lasse Reichstein Nielsen, 2016-03-01 15:22:42]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-03-01 15:22:43]

https://codereview.chromium.org/1728113002/diff/20001/lib/src/location.dart
File lib/src/location.dart (right):

https://codereview.chromium.org/1728113002/diff/20001/lib/src/location.dart#n...
lib/src/location.dart:23: final Uri _sourceUrl;
What does this change?

A field already introduces an implicit getter, so the external interface of the
class is unchanged by this modification.

Is it to allow subclasses inside the same package to overide the implicit
_sourceUrl getter?

The changelog text mentions strong mode. Does strong mode differentiate between
an implicit and an explicit getter? If so, it should be fixed.

[nweiz, 2016-03-01 19:16:10]

https://codereview.chromium.org/1728113002/diff/20001/lib/src/location.dart
File lib/src/location.dart (right):

https://codereview.chromium.org/1728113002/diff/20001/lib/src/location.dart#n...
lib/src/location.dart:23: final Uri _sourceUrl;
On 2016/03/01 15:22:42, Lasse Reichstein Nielsen wrote:
> What does this change?
> 
> A field already introduces an implicit getter, so the external interface of
the
> class is unchanged by this modification.
> 
> Is it to allow subclasses inside the same package to overide the implicit
> _sourceUrl getter?
> 
> The changelog text mentions strong mode. Does strong mode differentiate
between
> an implicit and an explicit getter? If so, it should be fixed.

Yes, it does. I'll forward you the email thread where we discussed it.

[Lasse Reichstein Nielsen, 2016-03-02 11:34:02]

LGTM.
It's your library, and the change is a no-op for Dart implementations.

If this is a temporary measure to appease a problem with strong mode, I'd rather
up-prioritize fixing the problem than changing existing packages - there are too
many packages to change anyway.

[Bob Nystrom, 2016-03-02 20:45:57]

lgtm

[nweiz, 2016-03-02 20:46:18]

Description was changed from

==========
Allow some fields to be overridden in strong mode.

For consistency, any field in a class that's meant to be extended can be
overridden.

R=rnystrom@google.com
==========

to

==========
Allow some fields to be overridden in strong mode.

For consistency, any field in a class that's meant to be extended can be
overridden.

R=lrn@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/source_span/commit/38273257d0bd61afd315ae7abaccc...
==========

[nweiz, 2016-03-02 20:46:20]

Committed patchset #2 (id:20001) manually as
38273257d0bd61afd315ae7abaccce603dc362e4 (presubmit successful).