Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2969)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1728083002: Extract a Connector interface from Shell that can be cloned & passed to other threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@12uid
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | content/test/data/web_ui_mojo_shell_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 96b971dfdf57e2106c8d681053a26a5229c5a855..c53f62782b946abf40f7dfbf6b94b1cc1120d019 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -6079,8 +6079,10 @@ mojo::shell::mojom::InterfaceProviderPtr RenderFrameImpl::ConnectToApplication(
mojo::Array<mojo::String> all_interfaces;
all_interfaces.push_back("*");
filter->filter.insert("*", std::move(all_interfaces));
- mojo_shell_->Connect(
- url.spec(), mojo::shell::mojom::Shell::kUserInherit,
+ mojo::shell::mojom::ConnectorPtr connector;
+ mojo_shell_->GetConnector(GetProxy(&connector));
+ connector->Connect(
+ url.spec(), mojo::shell::mojom::Connector::kUserInherit,
GetProxy(&interface_provider), nullptr, std::move(filter),
base::Bind(&OnGotInstanceID));
return interface_provider;
« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | content/test/data/web_ui_mojo_shell_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698