Extract a Connector interface from Shell that can be cloned & passed to other threads

mojo/shell/public/cpp/lib/connector_impl.cc

Index: mojo/shell/public/cpp/lib/connector_impl.cc
diff --git a/mojo/shell/public/cpp/lib/connector_impl.cc b/mojo/shell/public/cpp/lib/connector_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8f92d4c974672893fc0bba89b6516516d35bd33a
--- /dev/null
+++ b/mojo/shell/public/cpp/lib/connector_impl.cc
@@ -0,0 +1,72 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/shell/public/cpp/lib/connector_impl.h"
+
+#include "mojo/shell/public/cpp/lib/connection_impl.h"
+
+namespace mojo {
+
+Connector::ConnectParams::ConnectParams(const std::string& url)
+    : url_(url),
+      filter_(shell::mojom::CapabilityFilter::New()),
+      user_id_(shell::mojom::Connector::kUserInherit) {
+  filter_->filter.SetToEmpty();
+}
+Connector::ConnectParams::~ConnectParams() {}
+
+ConnectorImpl::ConnectorImpl(shell::mojom::ConnectorPtrInfo unbound_state)
+    : unbound_state_(std::move(unbound_state)) {}
+ConnectorImpl::~ConnectorImpl() {}
+
+scoped_ptr<Connection> ConnectorImpl::Connect(const std::string& url) {
+  ConnectParams params(url);
+  params.set_filter(CreatePermissiveCapabilityFilter());
+  return Connect(&params);
+}
+
+scoped_ptr<Connection> ConnectorImpl::Connect(ConnectParams* params) {
+  // Bind this object to the current thread the first time it is used to
+  // connect.
+  if (!connector_.is_bound()) {
+    if (!unbound_state_.is_valid())
+      return nullptr;
+    connector_.Bind(std::move(unbound_state_));

[sky, 2016/02/24 17:08:07]

It would be good if you add threadchecker to assert calls happen on the right
thread.

+  }
+
+  DCHECK(params);
+  std::string application_url = params->url().spec();
+  // We allow all interfaces on outgoing connections since we are presumably in
+  // a position to know who we're talking to.
+  // TODO(beng): is this a valid assumption or do we need to figure some way to
+  //             filter here too?
+  std::set<std::string> allowed;
+  allowed.insert("*");
+  shell::mojom::InterfaceProviderPtr local_interfaces;
+  shell::mojom::InterfaceProviderRequest local_request =
+      GetProxy(&local_interfaces);
+  shell::mojom::InterfaceProviderPtr remote_interfaces;
+  shell::mojom::InterfaceProviderRequest remote_request =
+      GetProxy(&remote_interfaces);
+  scoped_ptr<internal::ConnectionImpl> registry(new internal::ConnectionImpl(
+      application_url, application_url,
+      shell::mojom::Connector::kInvalidApplicationID, params->user_id(),
+      std::move(remote_interfaces), std::move(local_request), allowed));
+  connector_->Connect(application_url,
+                      params->user_id(),
+                      std::move(remote_request),
+                      std::move(local_interfaces),
+                      params->TakeFilter(),
+                      registry->GetConnectCallback());
+  return std::move(registry);
+}
+
+scoped_ptr<Connector> ConnectorImpl::Clone() {
+  shell::mojom::ConnectorPtr connector;
+  connector_->Clone(GetProxy(&connector));
+  return make_scoped_ptr(
+      new ConnectorImpl(connector.PassInterface()));
+}
+
+}  // namespace mojo