content/renderer/render_frame_impl.cc - Issue 1728083002: Extract a Connector interface from Shell that can be cloned & passed to other threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1728083002: Extract a Connector interface from Shell that can be cloned & passed to other threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@12uid

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index d94df1bcdbd9514e3307234845e1ff6a50884a38..b0927ffb3861ff60385114556737234b7f5919c9 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -6074,8 +6074,10 @@ mojo::shell::mojom::InterfaceProviderPtr RenderFrameImpl::ConnectToApplication(

mojo::Array<mojo::String> all_interfaces;

all_interfaces.push_back("*");

filter->filter.insert("*", std::move(all_interfaces));

- mojo_shell_->Connect(

- url.spec(), mojo::shell::mojom::Shell::kUserInherit,

+ mojo::shell::mojom::ConnectorPtr connector;

+ mojo_shell_->GetConnector(GetProxy(&connector));

+ connector->Connect(

+ url.spec(), mojo::shell::mojom::Connector::kUserInherit,

GetProxy(&interface_provider), nullptr, std::move(filter),

base::Bind(&OnGotInstanceID));

return interface_provider;

« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | content/test/data/web_ui_mojo_shell_test.js » ('j') | mojo/shell/public/cpp/connector.h » ('J')