Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/browser/mojo/mojo_shell_context.cc

Issue 1728083002: Extract a Connector interface from Shell that can be cloned & passed to other threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@12uid
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/mojo/mojo_shell_context.cc
diff --git a/content/browser/mojo/mojo_shell_context.cc b/content/browser/mojo/mojo_shell_context.cc
index 013b6ef263f3f499bce2d7a612b43455c1b751e7..c72113b49ce968c47a942f43781e50f07f8e93c4 100644
--- a/content/browser/mojo/mojo_shell_context.cc
+++ b/content/browser/mojo/mojo_shell_context.cc
@@ -160,7 +160,7 @@ class MojoShellContext::Proxy {
mojo::shell::mojom::InterfaceProviderRequest request,
mojo::shell::mojom::InterfaceProviderPtr exposed_services,
const mojo::shell::CapabilityFilter& filter,
- const mojo::shell::mojom::Shell::ConnectCallback& callback) {
+ const mojo::shell::mojom::Connector::ConnectCallback& callback) {
if (task_runner_ == base::ThreadTaskRunnerHandle::Get()) {
if (shell_context_) {
shell_context_->ConnectToApplicationOnOwnThread(
@@ -259,7 +259,7 @@ void MojoShellContext::ConnectToApplication(
mojo::shell::mojom::InterfaceProviderRequest request,
mojo::shell::mojom::InterfaceProviderPtr exposed_services,
const mojo::shell::CapabilityFilter& filter,
- const mojo::shell::mojom::Shell::ConnectCallback& callback) {
+ const mojo::shell::mojom::Connector::ConnectCallback& callback) {
proxy_.Get()->ConnectToApplication(url, requestor_url, std::move(request),
std::move(exposed_services), filter,
callback);
@@ -271,15 +271,15 @@ void MojoShellContext::ConnectToApplicationOnOwnThread(
mojo::shell::mojom::InterfaceProviderRequest request,
mojo::shell::mojom::InterfaceProviderPtr exposed_services,
const mojo::shell::CapabilityFilter& filter,
- const mojo::shell::mojom::Shell::ConnectCallback& callback) {
+ const mojo::shell::mojom::Connector::ConnectCallback& callback) {
scoped_ptr<mojo::shell::ConnectParams> params(new mojo::shell::ConnectParams);
// TODO(beng): kUserRoot is obviously wrong.
params->set_source(
mojo::shell::Identity(requestor_url, std::string(),
- mojo::shell::mojom::Shell::kUserRoot,
+ mojo::shell::mojom::Connector::kUserRoot,
mojo::shell::GetPermissiveCapabilityFilter()));
params->set_target(mojo::shell::Identity(
- url, std::string(), mojo::shell::mojom::Shell::kUserRoot, filter));
+ url, std::string(), mojo::shell::mojom::Connector::kUserRoot, filter));
params->set_remote_interfaces(std::move(request));
params->set_local_interfaces(std::move(exposed_services));
params->set_connect_callback(callback);

Powered by Google App Engine
This is Rietveld 408576698