components/security_interstitials/core/metrics_helper.cc - Issue 1728033002: components: Add out-of-line copy ctors for complex classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/metrics_helper.cc

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_interstitials/core/metrics_helper.h ('k') | components/sessions/core/serialized_navigation_entry.h » ('j') | components/url_matcher/url_matcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/metrics_helper.cc

diff --git a/components/security_interstitials/core/metrics_helper.cc b/components/security_interstitials/core/metrics_helper.cc

index 7b2e3cd1960f78a9b25dfc2bdec2ca1867e52710..eea0ce2c3d2945dfca8d6ec0e771b3aa9e758ec4 100644

--- a/components/security_interstitials/core/metrics_helper.cc

+++ b/components/security_interstitials/core/metrics_helper.cc

@@ -108,6 +108,9 @@ void MaybeRecordInteractionAsAction(MetricsHelper::Interaction interaction,

MetricsHelper::ReportDetails::ReportDetails()

: rappor_report_type(rappor::NUM_RAPPOR_TYPES) {}

+MetricsHelper::ReportDetails::ReportDetails(const ReportDetails& other) =

+ default;

MetricsHelper::MetricsHelper(const GURL& request_url,

const ReportDetails settings,

history::HistoryService* history_service,