components/omnibox/browser/shortcuts_database.h - Issue 1728033002: components: Add out-of-line copy ctors for complex classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/shortcuts_database.h

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/search_suggestion_parser.cc ('k') | components/omnibox/browser/shortcuts_database.cc » ('j') | components/url_matcher/url_matcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/shortcuts_database.h

diff --git a/components/omnibox/browser/shortcuts_database.h b/components/omnibox/browser/shortcuts_database.h

index 10d6a4ca09248b5100f4cea7dc02313e8540787c..7647a727bf39c36a2e8aae400acee85ef1eac2c9 100644

--- a/components/omnibox/browser/shortcuts_database.h

+++ b/components/omnibox/browser/shortcuts_database.h

@@ -51,6 +51,7 @@ class ShortcutsDatabase : public base::RefCountedThreadSafe<ShortcutsDatabase> {

int transition,

int type,

const base::string16& keyword);

+ MatchCore(const MatchCore& other);

~MatchCore();

base::string16 fill_into_edit;

@@ -74,6 +75,7 @@ class ShortcutsDatabase : public base::RefCountedThreadSafe<ShortcutsDatabase> {

int number_of_hits);

// Required for STL, we don't use this directly.

Shortcut();

+ Shortcut(const Shortcut& other);

~Shortcut();

std::string id; // Unique guid for the shortcut.