Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: components/history/core/browser/history_types.h

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_types.h
diff --git a/components/history/core/browser/history_types.h b/components/history/core/browser/history_types.h
index 94866c83968286e902c99190908d987a580b10bd..51e948c153a2ad054ebf1fe12794d12bfcfbcda5 100644
--- a/components/history/core/browser/history_types.h
+++ b/components/history/core/browser/history_types.h
@@ -315,6 +315,7 @@ struct MostVisitedURL {
MostVisitedURL(const GURL& url,
const base::string16& title,
const base::Time& last_forced_time);
+ MostVisitedURL(const MostVisitedURL& other);
~MostVisitedURL();
GURL url;
@@ -378,6 +379,7 @@ struct HistoryAddPageArgs {
ui::PageTransition transition,
VisitSource source,
bool did_replace_entry);
+ HistoryAddPageArgs(const HistoryAddPageArgs& other);
~HistoryAddPageArgs();
GURL url;
@@ -399,6 +401,7 @@ typedef std::vector<FilteredURL> FilteredURLList;
// Used by TopSites to store the thumbnails.
struct Images {
Images();
+ Images(const Images& other);
~Images();
scoped_refptr<base::RefCountedMemory> thumbnail;
@@ -417,6 +420,7 @@ typedef std::vector<MostVisitedURLWithRank> MostVisitedURLWithRankList;
struct TopSitesDelta {
TopSitesDelta();
+ TopSitesDelta(const TopSitesDelta& other);
~TopSitesDelta();
MostVisitedURLList deleted;
@@ -507,6 +511,7 @@ struct FaviconBitmapIDSize {
// Defines a favicon bitmap stored in the history backend.
struct FaviconBitmap {
FaviconBitmap();
+ FaviconBitmap(const FaviconBitmap& other);
~FaviconBitmap();
// The unique id of the bitmap.
@@ -530,6 +535,7 @@ struct FaviconBitmap {
struct ExpireHistoryArgs {
ExpireHistoryArgs();
+ ExpireHistoryArgs(const ExpireHistoryArgs& other);
~ExpireHistoryArgs();
// Sets |begin_time| and |end_time| to the beginning and end of the day (in

Powered by Google App Engine
This is Rietveld 408576698