components/cloud_devices/common/printer_description.cc - Issue 1728033002: components: Add out-of-line copy ctors for complex classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cloud_devices/common/printer_description.cc

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cloud_devices/common/printer_description.h ('k') | components/content_settings/core/browser/content_settings_rule.h » ('j') | components/url_matcher/url_matcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cloud_devices/common/printer_description.cc

diff --git a/components/cloud_devices/common/printer_description.cc b/components/cloud_devices/common/printer_description.cc

index 2602af8f1f8eaed231ced37374e9e57e147077ab..a5e03a0999ee9d6eb8c0662df369b59c5b3c4828 100644

--- a/components/cloud_devices/common/printer_description.cc

+++ b/components/cloud_devices/common/printer_description.cc

@@ -471,6 +471,8 @@ Media::Media(const std::string& custom_display_name,

custom_display_name(custom_display_name),

vendor_id(vendor_id) {}

+Media::Media(const Media& other) = default;

bool Media::MatchBySize() {

const MediaDefinition* media = FindMediaBySize(width_um, height_um);

if (!media)