Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: components/update_client/update_response.h

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_ 5 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_
6 #define COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_ 6 #define COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // 55 //
56 // The diff data members correspond to the differential update package, if 56 // The diff data members correspond to the differential update package, if
57 // a differential update is specified in the response. 57 // a differential update is specified in the response.
58 class UpdateResponse { 58 class UpdateResponse {
59 public: 59 public:
60 // The result of parsing one <app> tag in an xml update check response. 60 // The result of parsing one <app> tag in an xml update check response.
61 struct Result { 61 struct Result {
62 struct Manifest { 62 struct Manifest {
63 struct Package { 63 struct Package {
64 Package(); 64 Package();
65 Package(const Package& other);
65 ~Package(); 66 ~Package();
66 67
67 std::string fingerprint; 68 std::string fingerprint;
68 69
69 // Attributes for the full update. 70 // Attributes for the full update.
70 std::string name; 71 std::string name;
71 std::string hash_sha256; 72 std::string hash_sha256;
72 int size; 73 int size;
73 74
74 // Attributes for the differential update. 75 // Attributes for the differential update.
75 std::string namediff; 76 std::string namediff;
76 std::string hashdiff_sha256; 77 std::string hashdiff_sha256;
77 int sizediff; 78 int sizediff;
78 }; 79 };
79 80
80 Manifest(); 81 Manifest();
82 Manifest(const Manifest& other);
81 ~Manifest(); 83 ~Manifest();
82 84
83 std::string version; 85 std::string version;
84 std::string browser_min_version; 86 std::string browser_min_version;
85 std::vector<Package> packages; 87 std::vector<Package> packages;
86 }; 88 };
87 89
88 Result(); 90 Result();
91 Result(const Result& other);
89 ~Result(); 92 ~Result();
90 93
91 std::string extension_id; 94 std::string extension_id;
92 95
93 // The list of fallback urls, for full and diff updates respectively. 96 // The list of fallback urls, for full and diff updates respectively.
94 // These urls are base urls; they don't include the filename. 97 // These urls are base urls; they don't include the filename.
95 std::vector<GURL> crx_urls; 98 std::vector<GURL> crx_urls;
96 std::vector<GURL> crx_diffurls; 99 std::vector<GURL> crx_diffurls;
97 100
98 Manifest manifest; 101 Manifest manifest;
99 }; 102 };
100 103
101 static const int kNoDaystart = -1; 104 static const int kNoDaystart = -1;
102 struct Results { 105 struct Results {
103 Results(); 106 Results();
107 Results(const Results& other);
104 ~Results(); 108 ~Results();
105 109
106 // This will be >= 0, or kNoDaystart if the <daystart> tag was not present. 110 // This will be >= 0, or kNoDaystart if the <daystart> tag was not present.
107 int daystart_elapsed_seconds; 111 int daystart_elapsed_seconds;
108 std::vector<Result> list; 112 std::vector<Result> list;
109 }; 113 };
110 114
111 UpdateResponse(); 115 UpdateResponse();
112 ~UpdateResponse(); 116 ~UpdateResponse();
113 117
(...skipping 12 matching lines...) Expand all
126 130
127 // Adds parse error details to |errors_| string. 131 // Adds parse error details to |errors_| string.
128 void ParseError(const char* details, ...); 132 void ParseError(const char* details, ...);
129 133
130 DISALLOW_COPY_AND_ASSIGN(UpdateResponse); 134 DISALLOW_COPY_AND_ASSIGN(UpdateResponse);
131 }; 135 };
132 136
133 } // namespace update_client 137 } // namespace update_client
134 138
135 #endif // COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_ 139 #endif // COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698