Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: components/update_client/update_response.cc

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/update_client/update_response.h" 5 #include "components/update_client/update_response.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 static const char* kExpectedResponseProtocol = "3.0"; 22 static const char* kExpectedResponseProtocol = "3.0";
23 23
24 UpdateResponse::UpdateResponse() { 24 UpdateResponse::UpdateResponse() {
25 } 25 }
26 UpdateResponse::~UpdateResponse() { 26 UpdateResponse::~UpdateResponse() {
27 } 27 }
28 28
29 UpdateResponse::Results::Results() : daystart_elapsed_seconds(kNoDaystart) { 29 UpdateResponse::Results::Results() : daystart_elapsed_seconds(kNoDaystart) {
30 } 30 }
31 UpdateResponse::Results::Results(const Results& other) = default;
31 UpdateResponse::Results::~Results() { 32 UpdateResponse::Results::~Results() {
32 } 33 }
33 34
34 UpdateResponse::Result::Result() { 35 UpdateResponse::Result::Result() {
35 } 36 }
36 37 UpdateResponse::Result::Result(const Result& other) = default;
37 UpdateResponse::Result::~Result() { 38 UpdateResponse::Result::~Result() {
38 } 39 }
39 40
40 UpdateResponse::Result::Manifest::Manifest() { 41 UpdateResponse::Result::Manifest::Manifest() {
41 } 42 }
43 UpdateResponse::Result::Manifest::Manifest(const Manifest& other) = default;
42 UpdateResponse::Result::Manifest::~Manifest() { 44 UpdateResponse::Result::Manifest::~Manifest() {
43 } 45 }
44 46
45 UpdateResponse::Result::Manifest::Package::Package() : size(0), sizediff(0) { 47 UpdateResponse::Result::Manifest::Package::Package() : size(0), sizediff(0) {
46 } 48 }
49 UpdateResponse::Result::Manifest::Package::Package(const Package& other) =
50 default;
47 UpdateResponse::Result::Manifest::Package::~Package() { 51 UpdateResponse::Result::Manifest::Package::~Package() {
48 } 52 }
49 53
50 void UpdateResponse::ParseError(const char* details, ...) { 54 void UpdateResponse::ParseError(const char* details, ...) {
51 va_list args; 55 va_list args;
52 va_start(args, details); 56 va_start(args, details);
53 57
54 if (!errors_.empty()) { 58 if (!errors_.empty()) {
55 errors_ += "\r\n"; 59 errors_ += "\r\n";
56 } 60 }
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 results_.list.push_back(result); 346 results_.list.push_back(result);
343 } else { 347 } else {
344 ParseError("%s", error.c_str()); 348 ParseError("%s", error.c_str());
345 } 349 }
346 } 350 }
347 351
348 return true; 352 return true;
349 } 353 }
350 354
351 } // namespace update_client 355 } // namespace update_client
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698