Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: components/update_client/crx_update_item.h

Issue 1728033002: components: Add out-of-line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_UPDATE_CLIENT_CRX_UPDATE_ITEM_H_ 5 #ifndef COMPONENTS_UPDATE_CLIENT_CRX_UPDATE_ITEM_H_
6 #define COMPONENTS_UPDATE_CLIENT_CRX_UPDATE_ITEM_H_ 6 #define COMPONENTS_UPDATE_CLIENT_CRX_UPDATE_ITEM_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 int error_category; 110 int error_category;
111 int error_code; 111 int error_code;
112 int extra_code1; 112 int extra_code1;
113 int diff_error_category; 113 int diff_error_category;
114 int diff_error_code; 114 int diff_error_code;
115 int diff_extra_code1; 115 int diff_extra_code1;
116 116
117 std::vector<CrxDownloader::DownloadMetrics> download_metrics; 117 std::vector<CrxDownloader::DownloadMetrics> download_metrics;
118 118
119 CrxUpdateItem(); 119 CrxUpdateItem();
120 CrxUpdateItem(const CrxUpdateItem& other);
120 ~CrxUpdateItem(); 121 ~CrxUpdateItem();
121 122
122 // Function object used to find a specific component. 123 // Function object used to find a specific component.
123 class FindById { 124 class FindById {
124 public: 125 public:
125 explicit FindById(const std::string& id) : id_(id) {} 126 explicit FindById(const std::string& id) : id_(id) {}
126 127
127 bool operator()(CrxUpdateItem* item) const { return item->id == id_; } 128 bool operator()(CrxUpdateItem* item) const { return item->id == id_; }
128 129
129 private: 130 private:
130 const std::string& id_; 131 const std::string& id_;
131 }; 132 };
132 }; 133 };
133 134
134 } // namespace update_client 135 } // namespace update_client
135 136
136 #endif // COMPONENTS_UPDATE_CLIENT_CRX_UPDATE_ITEM_H_ 137 #endif // COMPONENTS_UPDATE_CLIENT_CRX_UPDATE_ITEM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698