Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: media/base/BUILD.gn

Issue 1727953005: Enable AudioDecoder unit tests on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile audio_decoder_unittest.cc only if media_use_ffmpeg is set Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/config/linux/pkg_config.gni") 9 import("//build/config/linux/pkg_config.gni")
10 import("//media/media_options.gni") 10 import("//media/media_options.gni")
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 "audio_renderer_mixer_unittest.cc", 388 "audio_renderer_mixer_unittest.cc",
389 "audio_shifter_unittest.cc", 389 "audio_shifter_unittest.cc",
390 "audio_splicer_unittest.cc", 390 "audio_splicer_unittest.cc",
391 "audio_timestamp_helper_unittest.cc", 391 "audio_timestamp_helper_unittest.cc",
392 "bind_to_current_loop_unittest.cc", 392 "bind_to_current_loop_unittest.cc",
393 "bit_reader_unittest.cc", 393 "bit_reader_unittest.cc",
394 "callback_holder.h", 394 "callback_holder.h",
395 "callback_holder_unittest.cc", 395 "callback_holder_unittest.cc",
396 "channel_mixer_unittest.cc", 396 "channel_mixer_unittest.cc",
397 "channel_mixing_matrix_unittest.cc", 397 "channel_mixing_matrix_unittest.cc",
398 "container_names_unittest.cc",
399 "data_buffer_unittest.cc", 398 "data_buffer_unittest.cc",
400 "decoder_buffer_queue_unittest.cc", 399 "decoder_buffer_queue_unittest.cc",
401 "decoder_buffer_unittest.cc", 400 "decoder_buffer_unittest.cc",
402 "djb2_unittest.cc", 401 "djb2_unittest.cc",
403 "fake_demuxer_stream_unittest.cc", 402 "fake_demuxer_stream_unittest.cc",
404 "gmock_callback_support_unittest.cc", 403 "gmock_callback_support_unittest.cc",
405 "key_systems_unittest.cc", 404 "key_systems_unittest.cc",
406 "mime_util_unittest.cc", 405 "mime_util_unittest.cc",
407 "moving_average_unittest.cc", 406 "moving_average_unittest.cc",
408 "multi_channel_resampler_unittest.cc", 407 "multi_channel_resampler_unittest.cc",
(...skipping 24 matching lines...) Expand all
433 ] 432 ]
434 deps = [ 433 deps = [
435 ":test_support", 434 ":test_support",
436 "//gpu/command_buffer/common", 435 "//gpu/command_buffer/common",
437 "//media", 436 "//media",
438 "//skia", 437 "//skia",
439 "//testing/gmock", 438 "//testing/gmock",
440 "//testing/gtest", 439 "//testing/gtest",
441 ] 440 ]
442 441
442 if (media_use_ffmpeg) {
DaleCurtis 2016/02/29 23:17:46 This doesn't require ffmpeg, why the move?
Tima Vaisburd 2016/03/01 00:14:22 Because container_names.h and .cc are conditionall
DaleCurtis 2016/03/01 00:16:37 Yes you should be able to include them uncondition
Tima Vaisburd 2016/03/01 00:48:55 Done.
443 sources += [ "container_names_unittest.cc" ]
444 }
445
443 # Even if FFmpeg is enabled on Android we don't want these. 446 # Even if FFmpeg is enabled on Android we don't want these.
444 # TODO(watk): Refactor tests that could be made to run on Android. 447 # TODO(watk): Refactor tests that could be made to run on Android.
445 if (media_use_ffmpeg && !is_android) { 448 if (media_use_ffmpeg && !is_android) {
446 sources += [ 449 sources += [
447 "audio_video_metadata_extractor_unittest.cc", 450 "audio_video_metadata_extractor_unittest.cc",
448 "media_file_checker_unittest.cc", 451 "media_file_checker_unittest.cc",
449 ] 452 ]
450 } 453 }
451 454
452 if (is_android) { 455 if (is_android) {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 } 552 }
550 553
551 fuzzer_test("media_container_names_fuzzer") { 554 fuzzer_test("media_container_names_fuzzer") {
552 sources = [ 555 sources = [
553 "container_names_fuzzertest.cc", 556 "container_names_fuzzertest.cc",
554 ] 557 ]
555 deps = [ 558 deps = [
556 "//media", 559 "//media",
557 ] 560 ]
558 } 561 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698