Enable AudioDecoder unit tests on Android

Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android, a hash value for one Opus decoded buffer is slightly off,
this CL also introduces and uses a hash comparison function that
accepts a tolerance.

BUG=542910
Committed: https://crrev.com/a212641db51b76b3a5c7c0e5d35b4126f226b63c
Cr-Commit-Position: refs/heads/master@{#378374}

[Tima Vaisburd, 2016-02-26 02:55:08]

timav@chromium.org changed reviewers:
+ dalecurtis@chromium.org, xhwang@chromium.org

[Tima Vaisburd, 2016-02-26 02:55:08]

This is preliminary step that's required for MediaCodecAudioDecoder unit tests.
Right now the audio decoder unit tests do not run on Android at all.
PTAL.

[Tima Vaisburd, 2016-02-26 02:55:29]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg                     decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
            that can work  for Chromium branding, currently
              Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
            decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL    introduced and uses a hash comparison function that
accepts    a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
            that can work  for Chromium branding, currently
              Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
            decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL    introduced and uses a hash comparison function that
accepts    a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 02:55:55]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
            that can work  for Chromium branding, currently
              Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
            decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL    introduced and uses a hash comparison function that
accepts    a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
            that can work  for Chromium branding, currently
              Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
            decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 02:56:30]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
            that can work  for Chromium branding, currently
              Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
            decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
          decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 02:58:09]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg
          expectations and instantiations for FFmpeg
          decoder tests.

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg.cc
          expectations and instantiations for FFmpeg
          decoder tests
and excluded the FFmeg tests on Android if ffmpeg_branding is "Chromium".

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 02:58:28]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg.cc
          expectations and instantiations for FFmpeg
          decoder tests
and excluded the FFmeg tests on Android if ffmpeg_branding is "Chromium".

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg.cc
          expectations and instantiations for FFmpeg
          decoder tests
and excluded the FFmeg tests on Android if ffmpeg_branding
is "Chromium".

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 02:58:46]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg.cc
          expectations and instantiations for FFmpeg
          decoder tests
and excluded the FFmeg tests on Android if ffmpeg_branding
is "Chromium".

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg.cc
          expectations and instantiations for FFmpeg
          decoder tests
and excluded the FFmpeg tests on Android if ffmpeg_branding
is "Chromium".

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 20:58:47]

timav@chromium.org changed reviewers:
+ watk@chromium.org

[Tima Vaisburd, 2016-02-26 20:58:48]

https://codereview.chromium.org/1727953005/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/20001/media/BUILD.gn#newcode749
media/BUILD.gn:749: if (!is_android || ffmpeg_branding == "Chrome") {
On GYP side ffmpeg_branding seems not defined for use in media and for GYP I
exclude audio_decoder_unittest_ffmpeg.cc for every Android build. Shall we do
the same here for simplicity until http://crbug.com/570762 is fixed?

[DaleCurtis, 2016-02-26 21:05:28]

I don't understand this split. The ffmpeg_branding thing should hopefully be
temporary; I have emails out to the lawyers right now to sort this out. I don't
want to split the file like this when the real issue is that proprietary_codecs
is a lie:

https://codereview.chromium.org/1577433004 is a CL I wrote to undo this lie --
the one issue is that we want to make sure AOSP WebView still gets aac, h264,
and mp3. So we need sign off from legal to flip that value and then update the
AOSP webview builders to set ffmpeg_branding=Chrome.

Splitting the classes like this doesn't feel like the right solution (though I
do like the new audio_decoder_test.h file)

[Tima Vaisburd, 2016-02-26 21:21:31]

On 2016/02/26 21:05:28, DaleCurtis wrote:
> I don't understand this split. The ffmpeg_branding thing should hopefully be
> temporary; I have emails out to the lawyers right now to sort this out. I
don't
> want to split the file like this when the real issue is that
proprietary_codecs
> is a lie:
> 
> https://codereview.chromium.org/1577433004 is a CL I wrote to undo this lie --
> the one issue is that we want to make sure AOSP WebView still gets aac, h264,
> and mp3. So we need sign off from legal to flip that value and then update the
> AOSP webview builders to set ffmpeg_branding=Chrome.
> 
> Splitting the classes like this doesn't feel like the right solution (though I
> do like the new audio_decoder_test.h file)

I'm working on CL that adds the MediaCodecAudioDecoder unit tests to
audio_decoder_unittest.cc.
If having these tests here is the right thing, we need to add the
audio_decoder_unittest.cc
to the Android build somehow.

I came up with this split to exclude ffmpeg tests, since there exists a
configuration where these
tests fail on Android. I thought that it would be good to control the inclusion
of this file
with the build flags rather than using some #define. I did not realize that
ffmpeg_branding
is a temporary thing.

What, in your opinion, is a better option?

Shall we have #ifdef block in audio_decoder_unittest.cc that excludes ffmpeg
tests on Android?

[DaleCurtis, 2016-02-26 21:23:06]

Yeah, I'd just disable the ffmpeg variants of this test on android for right
now.

[Tima Vaisburd, 2016-02-26 23:15:16]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

The file audio_decoder_unittests.cc contained test for
Opus and FFmpeg decoders. Currently on Android the FFmpeg
decoders can only work if ffmpeg_branding is "Chrome",
but not "Chromium".

This CL splits audio_decoder_unittest.cc into 4 parts:
  - audio_decoder_test.h
          the AudioDecoderTest class declaration,
  - audio_decoder_unittest.cc
          the implementation of AudioDecoderTest class
          and the parametric tests that use it,
  - audio_decoder_unittest_chromium.cc
          expectations and instantiations for tests
          that can work  for Chromium branding, currently
          Opus decoder tests,
  - audio_decoder_unittests_ffmpeg.cc
          expectations and instantiations for FFmpeg
          decoder tests
and excluded the FFmpeg tests on Android if ffmpeg_branding
is "Chromium".

On Android one hash for Opus decoder buffers is slightly off,
this CL introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android one hash for Opus decoder buffers is slightly off,
this CL also introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 23:16:32]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android one hash for Opus decoder buffers is slightly off,
this CL also introduced and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android, a hash value for one Opus decoded buffer is slightly off,
this CL also introduces and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[Tima Vaisburd, 2016-02-26 23:18:26]

On 2016/02/26 21:23:06, DaleCurtis wrote:
> Yeah, I'd just disable the ffmpeg variants of this test on android for right
> now.

Done (description updated), please take a look again.

[DaleCurtis, 2016-02-26 23:31:42]

https://codereview.chromium.org/1727953005/diff/40001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/40001/media/BUILD.gn#newcode738
media/BUILD.gn:738: if (media_use_ffmpeg || is_android) {
Just add the file after l.751

https://codereview.chromium.org/1727953005/diff/40001/media/base/audio_hash.h
File media/base/audio_hash.h (right):

https://codereview.chromium.org/1727953005/diff/40001/media/base/audio_hash.h...
media/base/audio_hash.h:46: // Compare with another hash value given as string
representation.
It's a bit odd having an equivalence test like this since the idea of the audio
hash is supposed to provide tolerance in the first place. That said, we get lots
of these tiny off by 1 errors, so perhaps this is nice.

https://codereview.chromium.org/1727953005/diff/40001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1727953005/diff/40001/media/media.gyp#newcode...
media/media.gyp:1387: ['media_use_ffmpeg==0 and OS!="android"', {
Just deleting l.1402 and leaving l.1381 should be sufficient.

[Tima Vaisburd, 2016-02-29 23:07:15]

https://codereview.chromium.org/1727953005/diff/40001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/40001/media/BUILD.gn#newcode738
media/BUILD.gn:738: if (media_use_ffmpeg || is_android) {
On 2016/02/26 23:31:42, DaleCurtis wrote:
> Just add the file after l.751

Done. This makes audio_decoder_unittest available on Android only if
media_use_ffmpeg is set, and on Android these test do not require ffmpeg at all!
I hope I understood your intention correctly.

https://codereview.chromium.org/1727953005/diff/40001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1727953005/diff/40001/media/media.gyp#newcode...
media/media.gyp:1387: ['media_use_ffmpeg==0 and OS!="android"', {
On 2016/02/26 23:31:42, DaleCurtis wrote:
> Just deleting l.1402 and leaving l.1381 should be sufficient.

Done, see the comment to the corresponding BUILD.gn change

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn
File media/BUILD.gn (left):

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn#oldcode419
media/BUILD.gn:419: if (!is_android || media_use_ffmpeg) {
GYP side seems to always include opus_audio_decoder, who is right?

[DaleCurtis, 2016-02-29 23:17:46]

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn
File media/BUILD.gn (left):

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn#oldcode419
media/BUILD.gn:419: if (!is_android || media_use_ffmpeg) {
On 2016/02/29 at 23:07:14, Tima Vaisburd wrote:
> GYP side seems to always include opus_audio_decoder, who is right?

GYP, no need to gate this here.

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn#newcode736
media/BUILD.gn:736: "filters/audio_decoder_unittest.cc",
If you want to add a #if defined(MEDIA_USE_FFMPEG) to the audio_decoder_unittest
we could include it unconditionally in the unittest list above (ditto for the
.gyp version).

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn#new...
media/base/BUILD.gn:442: if (media_use_ffmpeg) {
This doesn't require ffmpeg, why the move?

https://codereview.chromium.org/1727953005/diff/60001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1727953005/diff/60001/media/media.gyp#newcode...
media/media.gyp:1380: 'base/container_names_unittest.cc',
Same Q, why?

[Tima Vaisburd, 2016-03-01 00:14:23]

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn#newcode736
media/BUILD.gn:736: "filters/audio_decoder_unittest.cc",
On 2016/02/29 23:17:46, DaleCurtis wrote:
> If you want to add a #if defined(MEDIA_USE_FFMPEG) to the
audio_decoder_unittest
> we could include it unconditionally in the unittest list above (ditto for the
> .gyp version).

I tried and then discovered that audio_codec_unittest uses AVPacket and thus
requires media_use_ffmpeg as a whole. I was wrong in my prior comment. Shall we
keep this PS?

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn#new...
media/base/BUILD.gn:442: if (media_use_ffmpeg) {
On 2016/02/29 23:17:46, DaleCurtis wrote:
> This doesn't require ffmpeg, why the move?

Because container_names.h and .cc are conditionally included, see l.233.   I
think the current code does not compile with media_use_ffmpeg=false.

I did not see anything in container_names.* that requires ffmpeg though. Shall
we include them unconditionally?

[DaleCurtis, 2016-03-01 00:16:37]

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/BUILD.gn#newcode736
media/BUILD.gn:736: "filters/audio_decoder_unittest.cc",
On 2016/03/01 at 00:14:22, Tima Vaisburd wrote:
> On 2016/02/29 23:17:46, DaleCurtis wrote:
> > If you want to add a #if defined(MEDIA_USE_FFMPEG) to the
audio_decoder_unittest
> > we could include it unconditionally in the unittest list above (ditto for
the
> > .gyp version).
> 
> I tried and then discovered that audio_codec_unittest uses AVPacket and thus
requires media_use_ffmpeg as a whole. I was wrong in my prior comment. Shall we
keep this PS?

Ah yeah, thanks for the explanation, yeah lets keep this. I forgot we need
ffmpeg for demuxing here.

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn#new...
media/base/BUILD.gn:442: if (media_use_ffmpeg) {
On 2016/03/01 at 00:14:22, Tima Vaisburd wrote:
> On 2016/02/29 23:17:46, DaleCurtis wrote:
> > This doesn't require ffmpeg, why the move?
> 
> Because container_names.h and .cc are conditionally included, see l.233.   I
think the current code does not compile with media_use_ffmpeg=false.
> 
> I did not see anything in container_names.* that requires ffmpeg though. Shall
we include them unconditionally?

Yes you should be able to include them unconditionally.

[Tima Vaisburd, 2016-03-01 00:48:55]

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1727953005/diff/60001/media/base/BUILD.gn#new...
media/base/BUILD.gn:442: if (media_use_ffmpeg) {
On 2016/03/01 00:16:37, DaleCurtis wrote:
> On 2016/03/01 at 00:14:22, Tima Vaisburd wrote:
> > On 2016/02/29 23:17:46, DaleCurtis wrote:
> > > This doesn't require ffmpeg, why the move?
> > 
> > Because container_names.h and .cc are conditionally included, see l.233.   I
> think the current code does not compile with media_use_ffmpeg=false.
> > 
> > I did not see anything in container_names.* that requires ffmpeg though.
Shall
> we include them unconditionally?
> 
> Yes you should be able to include them unconditionally.

Done.

[DaleCurtis, 2016-03-01 00:50:44]

lgtm

[Tima Vaisburd, 2016-03-01 00:58:04]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2016-03-01 00:58:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1727953005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1727953005/80001

[commit-bot: I haz the power, 2016-03-01 01:06:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:06:48]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Tima Vaisburd, 2016-03-01 01:11:13]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1727953005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1727953005/80001

[commit-bot: I haz the power, 2016-03-01 02:27:20]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android, a hash value for one Opus decoded buffer is slightly off,
this CL also introduces and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android, a hash value for one Opus decoded buffer is slightly off,
this CL also introduces and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

[commit-bot: I haz the power, 2016-03-01 02:27:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-01 02:28:44]

Description was changed from

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android, a hash value for one Opus decoded buffer is slightly off,
this CL also introduces and uses a hash comparison function that
accepts a tolerance.

BUG=542910
==========

to

==========
Enable AudioDecoder unit tests on Android

Disabled FFmpeg decoder tests on Android in audio_decoder_unittests.cc
and included this file in the build on Android platform.

On Android, a hash value for one Opus decoded buffer is slightly off,
this CL also introduces and uses a hash comparison function that
accepts a tolerance.

BUG=542910

Committed: https://crrev.com/a212641db51b76b3a5c7c0e5d35b4126f226b63c
Cr-Commit-Position: refs/heads/master@{#378374}
==========

[commit-bot: I haz the power, 2016-03-01 02:28:45]

Patchset 5 (id:??) landed as
https://crrev.com/a212641db51b76b3a5c7c0e5d35b4126f226b63c
Cr-Commit-Position: refs/heads/master@{#378374}