Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 172793006: Disable imageresizetiled GM for now due to rtree and tilegrid failures. (Closed)

Created:
6 years, 10 months ago by Stephen White
Modified:
6 years, 10 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Disable imageresizetiled GM for now due to rtree and tilegrid failures. TBR=scroggo@google.com BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13507

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gyp/gmslides.gypi View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
Committed patchset #1 manually as r13507 (presubmit successful).
6 years, 10 months ago (2014-02-19 22:36:35 UTC) #1
scroggo
https://codereview.chromium.org/172793006/diff/1/gyp/gmslides.gypi File gyp/gmslides.gypi (right): https://codereview.chromium.org/172793006/diff/1/gyp/gmslides.gypi#newcode95 gyp/gmslides.gypi:95: #'../gm/imageresizetiled.cpp', Should we instead add a flag to skip ...
6 years, 10 months ago (2014-02-19 22:47:01 UTC) #2
reed1
will this not, in turn, have issues when used in chrome, that drawing tiled?
6 years, 10 months ago (2014-02-20 00:51:31 UTC) #3
Stephen White
On 2014/02/20 00:51:31, reed1 wrote: > will this not, in turn, have issues when used ...
6 years, 10 months ago (2014-02-20 15:59:19 UTC) #4
Stephen White
6 years, 10 months ago (2014-02-20 15:59:56 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/172793006/diff/1/gyp/gmslides.gypi
File gyp/gmslides.gypi (right):

https://codereview.chromium.org/172793006/diff/1/gyp/gmslides.gypi#newcode95
gyp/gmslides.gypi:95: #'../gm/imageresizetiled.cpp',
On 2014/02/19 22:47:01, scroggo wrote:
> Should we instead add a flag to skip only rtree and tilegrid (is the error on
> record or playback? We could be more or less general), while still running the
> GM in other modes?
> 
> (GM flags are here:
> https://code.google.com/p/skia/source/browse/trunk/gm/gm.h#39)

Yes, we should do that. I was just in a hurry to get the tree green.

Powered by Google App Engine
This is Rietveld 408576698