Remove PlatformThemeChromiumDefault as it is dead code

Remove PlatformThemeChromiumDefault as it is dead code

There are only two calls to it in WebViewImpl but those has no effect.

R=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159988

[jochen (gone - plz use gerrit), 2013-06-17 14:20:50]

hum, if I'm not mistaken, this is used e.g. for aura builds?

[kbalazs_, 2013-06-17 14:28:07]

On 2013/06/17 14:20:50, jochen wrote:
> hum, if I'm not mistaken, this is used e.g. for aura builds?

The default render theme is but this thing is not used anywhere, at least if I
can use grep ;)

[jochen (gone - plz use gerrit), 2013-06-17 14:32:27]

On 2013/06/17 14:28:07, kbalazs wrote:
> On 2013/06/17 14:20:50, jochen wrote:
> > hum, if I'm not mistaken, this is used e.g. for aura builds?
> 
> The default render theme is but this thing is not used anywhere, at least if I
> can use grep ;)

what about this:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...

[kbalazs_, 2013-06-17 14:40:42]

On 2013/06/17 14:32:27, jochen wrote:
> On 2013/06/17 14:28:07, kbalazs wrote:
> > On 2013/06/17 14:20:50, jochen wrote:
> > > hum, if I'm not mistaken, this is used e.g. for aura builds?
> > 
> > The default render theme is but this thing is not used anywhere, at least if
I
> > can use grep ;)
> 
> what about this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...

This is why I did not remove this api yet (it will be a patch for chromium
anyway). But it just sets some static vars that are supposed to be used in
WebKit. But they are not. So the api does not have effect.

[jochen (gone - plz use gerrit), 2013-06-17 14:54:18]

On 2013/06/17 14:40:42, kbalazs wrote:
> On 2013/06/17 14:32:27, jochen wrote:
> > On 2013/06/17 14:28:07, kbalazs wrote:
> > > On 2013/06/17 14:20:50, jochen wrote:
> > > > hum, if I'm not mistaken, this is used e.g. for aura builds?
> > > 
> > > The default render theme is but this thing is not used anywhere, at least
if
> I
> > > can use grep ;)
> > 
> > what about this:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...
> 
> This is why I did not remove this api yet (it will be a patch for chromium
> anyway). But it just sets some static vars that are supposed to be used in
> WebKit. But they are not. So the api does not have effect.

When I build content shell with and without your patch, and select some text on
google.com, I get different selection colors (white vs black font, different
kind of background blue)

[kbalazs_, 2013-06-17 17:29:58]

> 
> When I build content shell with and without your patch, and select some text
on
> http://google.com, I get different selection colors (white vs black font,
different
> kind of background blue)

Very strange. I still cannot find any reference to this. Thanks for your time on
finding it out. I will try to catch it in a debug build a bit later.

[jochen (gone - plz use gerrit), 2013-06-17 20:08:39]

On 2013/06/17 17:29:58, kbalazs wrote:
> > 
> > When I build content shell with and without your patch, and select some text
> on
> > http://google.com, I get different selection colors (white vs black font,
> different
> > kind of background blue)
> 
> Very strange. I still cannot find any reference to this. Thanks for your time
on
> finding it out. I will try to catch it in a debug build a bit later.

If you follow the codesearch link, you should be able to click on cross-refs to
see all the callsites etc..

[kbalazs_, 2013-06-19 08:46:55]

On 2013/06/17 20:08:39, jochen wrote:
> On 2013/06/17 17:29:58, kbalazs wrote:
> > > 
> > > When I build content shell with and without your patch, and select some
text
> > on
> > > http://google.com, I get different selection colors (white vs black font,
> > different
> > > kind of background blue)
> > 
> > Very strange. I still cannot find any reference to this. Thanks for your
time
> on
> > finding it out. I will try to catch it in a debug build a bit later.
> 
> If you follow the codesearch link, you should be able to click on cross-refs
to
> see all the callsites etc..

Sorry for being blind but I still only see that setScrollbarColors is called but
I don't see where are those values are used (or anything from this class). I
cannot see any visual difference either.

[jochen (gone - plz use gerrit), 2013-09-12 09:30:03]

On 2013/06/19 08:46:55, kbalazs wrote:
> On 2013/06/17 20:08:39, jochen wrote:
> > On 2013/06/17 17:29:58, kbalazs wrote:
> > > > 
> > > > When I build content shell with and without your patch, and select some
> text
> > > on
> > > > http://google.com, I get different selection colors (white vs black
font,
> > > different
> > > > kind of background blue)
> > > 
> > > Very strange. I still cannot find any reference to this. Thanks for your
> time
> > on
> > > finding it out. I will try to catch it in a debug build a bit later.
> > 
> > If you follow the codesearch link, you should be able to click on cross-refs
> to
> > see all the callsites etc..
> 
> Sorry for being blind but I still only see that setScrollbarColors is called
but
> I don't see where are those values are used (or anything from this class). I
> cannot see any visual difference either.

setScrollbarColors seems to be dead code indeed. The selection colors however
weren't.

The class was rewritten meanwhile, would you mind to update your patch?

[kbalazs_, 2013-10-06 04:26:46]

Sure, I will update it. I think I can get to it next week.

[kbalazs_, 2013-10-16 18:39:36]

Updated.

[jochen (gone - plz use gerrit), 2013-10-17 22:39:52]

lgtm

[commit-bot: I haz the power, 2013-10-18 01:06:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/17279002/13001

[commit-bot: I haz the power, 2013-10-18 01:06:43]

Failed to apply patch for Source/core/core.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/core.gypi
  Hunk #1 FAILED at 2695.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/core.gypi.rej

Patch:       Source/core/core.gypi
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index
d4d3f58b6bc3131ae624928a1f9e970ad3a8658c..c62bdf8b8808f62ab34c522054409d65971a8fb2
100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -2695,8 +2695,6 @@
             'platform/chromium/MemoryUsageSupportChromium.cpp',
             'platform/chromium/MIMETypeRegistryChromium.cpp',
             'platform/chromium/PlatformScreenChromium.cpp',
-            'platform/chromium/PlatformThemeChromiumDefault.cpp',
-            'platform/chromium/PlatformThemeChromiumDefault.h',
             'platform/chromium/PlatformSpeechSynthesizerChromium.cpp',
             'platform/graphics/BitmapImage.cpp',
             'platform/graphics/ContentDecryptionModule.cpp',

[commit-bot: I haz the power, 2013-10-18 20:04:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/17279002/38001

[commit-bot: I haz the power, 2013-10-19 01:18:30]

Change committed as 159988