Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1727833006: [runtime] Make target checking for %Call and %_Call consistent. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
mvstanton, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy, mythria
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Make target checking for %Call and %_Call consistent. The %_Call intrinsic (if supported by the compiler) is lowered directly to the Call builtin and thus throws a TypeError if the target is not callable. The %Call runtime function also eventually calls into the Call builtin, but had an early abort if the target is not a JSReceiver, which is unnecessary and leads to various test failures for Ignition. R=mvstanton@chromium.org Committed: https://crrev.com/458764621b2b667ea349d0a8fd8361cc99d7bf51 Cr-Commit-Position: refs/heads/master@{#34316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/runtime/runtime-function.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/call-intrinsic-type-error.js View 1 chunk +5 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
4 years, 9 months ago (2016-02-26 06:39:07 UTC) #1
Benedikt Meurer
Hey Michael, Here's an easy consistency fix for %Call vs %_Call, which was blowing up ...
4 years, 9 months ago (2016-02-26 06:40:14 UTC) #2
mvstanton
lgtm
4 years, 9 months ago (2016-02-26 06:42:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727833006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727833006/1
4 years, 9 months ago (2016-02-26 06:43:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 06:59:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/458764621b2b667ea349d0a8fd8361cc99d7bf51 Cr-Commit-Position: refs/heads/master@{#34316}
4 years, 9 months ago (2016-02-26 07:00:42 UTC) #8
rmcilroy
4 years, 9 months ago (2016-02-26 08:40:11 UTC) #10
Message was sent while issue was closed.
Awesome thanks Benedikt. +Mythri who was looking at these test failures
yesterday.

Powered by Google App Engine
This is Rietveld 408576698