Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172783003: rAc: don't show countries with partially supported address fields for now. (Closed)

Created:
6 years, 10 months ago by Dan Beam
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: don't show countries with partially supported address fields for now. TODO(dbeam): re-enable when we figure out how a webpage can request this field. R=estade@chromium.org, rouslan@chromium.org BUG=340929 TEST=unit_tests, no CN or KR in rAc() country dropdown or suggestions for now :( Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252167

Patch Set 1 : tests #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : compile #

Messages

Total messages: 14 (0 generated)
Dan Beam
6 years, 10 months ago (2014-02-19 19:43:31 UTC) #1
please use gerrit instead
lgtm with a nit, but I'm not an owner in autofill. https://codereview.chromium.org/172783003/diff/30001/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc File chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc (right): ...
6 years, 10 months ago (2014-02-19 20:09:12 UTC) #2
Dan Beam
> lgtm with a nit, but I'm not an owner in autofill. I am :) ...
6 years, 10 months ago (2014-02-19 20:16:53 UTC) #3
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 10 months ago (2014-02-19 20:16:57 UTC) #4
Evan Stade
lgtm
6 years, 10 months ago (2014-02-19 20:19:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/172783003/150001
6 years, 10 months ago (2014-02-19 20:26:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 21:05:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-19 21:05:25 UTC) #8
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 10 months ago (2014-02-19 21:45:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/172783003/380001
6 years, 10 months ago (2014-02-19 22:14:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/172783003/380001
6 years, 10 months ago (2014-02-20 00:44:01 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 01:31:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-20 01:31:14 UTC) #13
Dan Beam
6 years, 10 months ago (2014-02-20 04:00:07 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 manually as r252167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698