Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2093)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1727823002: [Herb] Add metrics to track button usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Hard-coded histogram name Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 0c00788997a518239244fc8f632828e5c67a17ec..c87e2fa3432c35d22d12e63c39b08017f3010c0f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -237,6 +237,7 @@ public class CustomTabActivity extends ChromeActivity {
if (mIntentDataProvider.isOpenedByBrowser()) {
createHerbResultIntent(RESULT_CLOSED);
}
+ RecordUserAction.record("CustomTabs.CloseButtonClicked");
CustomTabActivity.this.finish();
}
});
@@ -438,6 +439,8 @@ public class CustomTabActivity extends ChromeActivity {
@Override
protected boolean handleBackPressed() {
+ RecordUserAction.record("CustomTabs.SystemBack");
+
if (getActivityTab() == null) return false;
if (exitFullscreenIfShowing()) return true;
@@ -471,6 +474,8 @@ public class CustomTabActivity extends ChromeActivity {
ApiCompatibilityUtils.getCreatorPackage(params.getPendingIntent());
if (mIntentDataProvider.finishAfterOpeningInBrowser()
&& TextUtils.equals(getPackageName(), creatorPackage)) {
+ RecordUserAction.record(
+ "TaskManagement.OpenInChromeActionButtonClicked");
openCurrentUrlInBrowser();
finish();
} else {

Powered by Google App Engine
This is Rietveld 408576698