[Herb] Add metrics to track button usage

tools/metrics/actions/actions.xml

Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 03d73bd414cef53ccd82709b785cab653a46edc0..ad080299c423c35bd6c130c0f9fe86009864bbbd 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -2521,6 +2521,18 @@ should be able to be added at any place in this file.
   <obsolete>Deprecated as of 11/2015.</obsolete>
 </action>
 
+<action name="CustomTabs.CloseButtonClicked">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>Close button of the CustomTabActivity was clicked.</description>
+</action>
+
+<action name="CustomTabs.SystemBackFinishedApp">

[Ilya Sherman, 2016/02/25 21:41:25]

If recording this as a user action, I think it makes sense to just emit
"CustomTabs.SystemBack".  The user action is hitting the system back button --
even if the semantics of that action change over time, the user action will
remain the same.

[gone, 2016/02/25 22:18:14]

Done.  I'll probably end up refactoring out the back pressed histogram in
ChromeTabbedActivity in a later CL, but I'd rather have some metrics now than
all the metrics later.

+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    CustomTabActivity closed because user hit the 'back' button.
+  </description>
+</action>
+
 <action name="CustomTabsCustomActionButtonClick">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of the metric.</description>
@@ -12971,8 +12983,11 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="SystemBackForNavigation">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <description>Please enter the description of this user action.</description>
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    The user navigated backward in the tab's history using the system back
+    button.

[Ilya Sherman, 2016/02/25 21:41:25]

Is this metric mutually exclusive with SystemBack, or are they always recorded
together in case of navigation?

[gone, 2016/02/25 22:18:14]

After my changes to record SystemBack at the top, SystemBackForNavigation will
always be recorded.  That being said, I don't think it's all that useful an
action now that there's a proper histogram.  I'd actually deleted it in an
earlier patch.  I've just straight up deprecated it.

+  </description>
 </action>
 
 <action name="TabContextMenu_BookmarkAllTabs">
@@ -13123,6 +13138,24 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="TaskManagement.OpenInChromeActionButtonClicked">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    User hit the &quot;Open in Chrome&quot; action button.
+  </description>
+</action>
+
+<action name="TaskManagement.ReturnButtonClicked">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    User hit the &quot;X&quot; button to close the tab. The return button is an
+    explicit &quot;close this tab and return to the previous app&quot; button
+    that may appear to the left of the Omnibox.  This is different from regular
+    tab closing buttons because those doesn't send the user back to the previous
+    app.
+  </description>
+</action>
+
 <action name="TaskManager">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>