Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1727793002: Remove FXSYS_Div. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove FXSYS_Div. This is just a wrapper for (a) / (b). Inline the divide. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/affe4b09575b297747e66bd0b807d2b1b04822fe

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Review fixes #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -60 lines) Patch
M core/include/fxcrt/fx_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 4 chunks +17 lines, -15 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_progress.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/agg23/agg_clip_liang_barsky.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/agg23/agg_math_stroke.h View 3 chunks +6 lines, -5 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_graphics.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_path_generator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-23 20:41:32 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1727793002/diff/20001/core/src/fpdfapi/fpdf_page/fpdf_page.cpp File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right): https://codereview.chromium.org/1727793002/diff/20001/core/src/fpdfapi/fpdf_page/fpdf_page.cpp#newcode755 core/src/fpdfapi/fpdf_page/fpdf_page.cpp:755: display_matrix.Set((((FX_FLOAT)(x2 - x0)) / m_PageWidth), too many parenthesis? ...
4 years, 10 months ago (2016-02-23 20:48:21 UTC) #3
dsinclair
https://codereview.chromium.org/1727793002/diff/20001/core/src/fpdfapi/fpdf_page/fpdf_page.cpp File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right): https://codereview.chromium.org/1727793002/diff/20001/core/src/fpdfapi/fpdf_page/fpdf_page.cpp#newcode755 core/src/fpdfapi/fpdf_page/fpdf_page.cpp:755: display_matrix.Set((((FX_FLOAT)(x2 - x0)) / m_PageWidth), On 2016/02/23 20:48:21, Lei ...
4 years, 10 months ago (2016-02-23 21:04:16 UTC) #4
dsinclair
Committed patchset #4 (id:60001) manually as affe4b09575b297747e66bd0b807d2b1b04822fe (presubmit successful).
4 years, 10 months ago (2016-02-23 21:05:03 UTC) #6
Lei Zhang
4 years, 10 months ago (2016-02-23 21:18:43 UTC) #7
Message was sent while issue was closed. 
On 2016/02/23 21:04:16, dsinclair wrote:
> Made it not mixed, but it's still wrong. The whole file will need to move to 2
> space from 4 space indent to make git cl format happy with it.

Maybe we should tell git cl format to stop formatting third_party.

Powered by Google App Engine
This is Rietveld 408576698