Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 17277002: Allow running mjsunit/manual-parallel-recompile on single-core systems. (Closed)

Created:
7 years, 6 months ago by kilvadyb
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow running mjsunit/manual-parallel-recompile on single-core systems. - Add an %IsParallelSupported() builtin function to make possible to check support of parallel processing from JavaScripts. - Change the test script that if parallel recompilation is forced on a single core CPU, expect that it won't be recompiled in parallel. - Change the JSFunction::MarkForParallelRecompilation() to fall back gracefully if parallel recompilation is not supported. BUG=v8:2733 TEST=mjsunit/manual-parallel-recompile

Patch Set 1 #

Total comments: 2

Patch Set 2 : Function renamed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/manual-parallel-recompile.js View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
LGTM. Thanks for fixing this! https://codereview.chromium.org/17277002/diff/1/src/runtime.h File src/runtime.h (right): https://codereview.chromium.org/17277002/diff/1/src/runtime.h#newcode98 src/runtime.h:98: F(IsParallelSupported, 0, 1) \ ...
7 years, 6 months ago (2013-06-17 14:07:58 UTC) #1
kilvadyb
https://codereview.chromium.org/17277002/diff/1/src/runtime.h File src/runtime.h (right): https://codereview.chromium.org/17277002/diff/1/src/runtime.h#newcode98 src/runtime.h:98: F(IsParallelSupported, 0, 1) \ On 2013/06/17 14:07:58, Yang wrote: ...
7 years, 6 months ago (2013-06-17 16:02:36 UTC) #2
palfia
7 years, 6 months ago (2013-06-17 16:27:53 UTC) #3
Committed as r15184.

Powered by Google App Engine
This is Rietveld 408576698