Refactor lithium codegen to not pass around block_ids

Lithium codegen should not pass around block_ids. Rather encapsulate the basic block to assembly label mapping in the LInstruction.

BUG=
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15235

[Jakob Kummerow, 2013-06-18 09:35:38]

LGTM with comments that apply to all platforms.

https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-codegen-i...
File src/ia32/lithium-codegen-ia32.h (right):

https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-codegen-i...
src/ia32/lithium-codegen-ia32.h:320: void EmitBranch(InstrType instr, Condition
cc);
Instead of templatizing this, can you change the signature to
"EmitBranch(LControlInstruction* instr, Condition cc)", or does that make the
compiler unhappy?

https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):

https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-ia32.h#ne...
src/ia32/lithium-ia32.h:486: false_label_ = true_label_ = NULL;
nit: Use initializers:

  LControlInstruction() : false_label_(NULL), true_label_(NULL) {}

[oliv, 2013-06-19 10:54:07]

On 2013/06/18 09:35:38, Jakob wrote:
> LGTM with comments that apply to all platforms.
> 
>
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-codegen-i...
> File src/ia32/lithium-codegen-ia32.h (right):
> 
>
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-codegen-i...
> src/ia32/lithium-codegen-ia32.h:320: void EmitBranch(InstrType instr,
Condition
> cc);
> Instead of templatizing this, can you change the signature to
> "EmitBranch(LControlInstruction* instr, Condition cc)", or does that make the
> compiler unhappy?

unfortunately the compiler is very unhappy otherwise, since LControlInstruction
is a Template itself.
 
> https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-ia32.h
> File src/ia32/lithium-ia32.h (right):
> 
>
https://codereview.chromium.org/17276002/diff/4001/src/ia32/lithium-ia32.h#ne...
> src/ia32/lithium-ia32.h:486: false_label_ = true_label_ = NULL;
> nit: Use initializers:
> 
>   LControlInstruction() : false_label_(NULL), true_label_(NULL) {}

[Jakob Kummerow, 2013-06-19 13:10:50]

> > Instead of templatizing this, can you change the signature to
> > "EmitBranch(LControlInstruction* instr, Condition cc)", or does that make
the
> > compiler unhappy?
> 
> unfortunately the compiler is very unhappy otherwise, since
LControlInstruction
> is a Template itself.

I suspected as much.

LGTM.

[oliv, 2013-06-20 11:51:00]

Committed patchset #3 manually as r15235 (presubmit successful).