Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Side by Side Diff: src/preparser.cc

Issue 172753002: Re-enable Parser::symbol_cache_ (after a long time!) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: adding safeguards Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/parser.cc ('k') | test/cctest/cctest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1166 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 LogSymbol(); 1177 LogSymbol();
1178 break; 1178 break;
1179 case Token::NUMBER: 1179 case Token::NUMBER:
1180 Consume(next); 1180 Consume(next);
1181 checker.CheckProperty(next, kValueProperty, CHECK_OK); 1181 checker.CheckProperty(next, kValueProperty, CHECK_OK);
1182 break; 1182 break;
1183 default: 1183 default:
1184 if (Token::IsKeyword(next)) { 1184 if (Token::IsKeyword(next)) {
1185 Consume(next); 1185 Consume(next);
1186 checker.CheckProperty(next, kValueProperty, CHECK_OK); 1186 checker.CheckProperty(next, kValueProperty, CHECK_OK);
1187 LogSymbol();
1187 } else { 1188 } else {
1188 // Unexpected token. 1189 // Unexpected token.
1189 *ok = false; 1190 *ok = false;
1190 return Expression::Default(); 1191 return Expression::Default();
1191 } 1192 }
1192 } 1193 }
1193 1194
1194 Expect(Token::COLON, CHECK_OK); 1195 Expect(Token::COLON, CHECK_OK);
1195 ParseAssignmentExpression(true, CHECK_OK); 1196 ParseAssignmentExpression(true, CHECK_OK);
1196 1197
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1376 int identifier_pos = position(); 1377 int identifier_pos = position();
1377 if (scanner()->is_literal_ascii()) { 1378 if (scanner()->is_literal_ascii()) {
1378 log_->LogAsciiSymbol(identifier_pos, scanner()->literal_ascii_string()); 1379 log_->LogAsciiSymbol(identifier_pos, scanner()->literal_ascii_string());
1379 } else { 1380 } else {
1380 log_->LogUtf16Symbol(identifier_pos, scanner()->literal_utf16_string()); 1381 log_->LogUtf16Symbol(identifier_pos, scanner()->literal_utf16_string());
1381 } 1382 }
1382 } 1383 }
1383 1384
1384 1385
1385 } } // v8::internal 1386 } } // v8::internal
OLDNEW
« no previous file with comments | « src/parser.cc ('k') | test/cctest/cctest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698