Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1727453003: [interpreter,debugger] Unskip debug tests for Ignition. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter,debugger] Unskip debug tests for ignition. TBR=rmcilroy@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/113d303534eda44d0543bf2c712fc88aea0b83e0 Cr-Commit-Position: refs/heads/master@{#34214}

Patch Set 1 #

Patch Set 2 : also cctests #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -3 lines) Patch
M test/cctest/cctest.status View 1 2 1 chunk +22 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
Yang
4 years, 10 months ago (2016-02-23 14:00:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727453003/1
4 years, 10 months ago (2016-02-23 14:00:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727453003/20001
4 years, 10 months ago (2016-02-23 14:46:54 UTC) #7
rmcilroy
Awesome, lgtm, thanks!
4 years, 10 months ago (2016-02-23 14:53:11 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/12637)
4 years, 10 months ago (2016-02-23 15:09:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727453003/40001
4 years, 10 months ago (2016-02-23 15:15:10 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 15:34:16 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 15:34:55 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/113d303534eda44d0543bf2c712fc88aea0b83e0
Cr-Commit-Position: refs/heads/master@{#34214}

Powered by Google App Engine
This is Rietveld 408576698