Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 17274002: Revert 24086 Update checked in binary to version 0.5.19.0 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 24095)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -17,6 +17,7 @@
import "dart:async";
import "dart:io";
import "dart:isolate";
+import "dart:uri";
import "drt_updater.dart";
import "multitest.dart";
import "status_file_parser.dart";
@@ -48,7 +49,7 @@
* completes immediately with `null`.
*/
Future asynchronously(function()) {
- if (function == null) return new Future.value(null);
+ if (function == null) return new Future.immediate(null);
var completer = new Completer();
Timer.run(() => completer.complete(function()));
@@ -489,7 +490,7 @@
var snapshotPath = TestUtils.absolutePath(new Path(buildDir).join(
new Path('dart-sdk/bin/snapshots/'
'utils_wrapper.dart.snapshot'))).toString();
- return [new Uri(scheme: 'file', path: snapshotPath)];
+ return [new Uri.fromComponents(scheme: 'file', path: snapshotPath)];
}
/**
@@ -539,7 +540,7 @@
var completer = new Completer();
var updater = runtimeUpdater(configuration);
if (updater == null || updater.updated) {
- return new Future.value(null);
+ return new Future.immediate(null);
}
assert(updater.isActive);
@@ -589,7 +590,7 @@
return dir.exists().then((exists) {
if (!exists) {
print('Directory containing tests missing: ${suiteDir.toNativePath()}');
- return new Future.value(null);
+ return new Future.immediate(null);
} else {
var group = new FutureGroup();
enqueueDirectory(dir, group);
@@ -882,7 +883,7 @@
void _createWrapperFile(String dartWrapperFilename, dartLibraryFilename) {
File file = new File(dartWrapperFilename);
- RandomAccessFile dartWrapper = file.openSync(mode: FileMode.WRITE);
+ RandomAccessFile dartWrapper = file.openSync(FileMode.WRITE);
var usePackageImport = dartLibraryFilename.segments().contains("pkg");
var libraryPathComponent = _createUrlPathFromFile(dartLibraryFilename);
@@ -945,8 +946,7 @@
scriptPath = _createUrlPathFromFile(new Path(scriptPath));
// Create the HTML file for the test.
- RandomAccessFile htmlTest =
- new File(htmlPath).openSync(mode: FileMode.WRITE);
+ RandomAccessFile htmlTest = new File(htmlPath).openSync(FileMode.WRITE);
String content = null;
Path dir = filePath.directoryPath;
String nameNoExt = filePath.filenameWithoutExtension;
@@ -1729,7 +1729,7 @@
static String testScriptPath = new Options().script;
static LastModifiedCache lastModifiedCache = new LastModifiedCache();
static Path currentWorkingDirectory =
- new Path(Directory.current.path);
+ new Path(new Directory.current().path);
/**
* Creates a directory using a [relativePath] to an existing
* [base] directory if that [relativePath] does not already exist.
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698