Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1727363005: OSX: Allow to load libsasl2.2.dylib and libcrypto.0.9.8.dylib in sandbox. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
Robert Sesek, Greg K
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OSX: Allow to load libsasl2.2.dylib and libcrypto.0.9.8.dylib in sandbox. On El Capitan, NSSearchFieldCell requires libcldcpuengine.dylib and it depends on libsasl2.2.dylib and libcrypto.0.9.8.dylib. We need to specify them in renderer.sb in order that "Content Shell --run-layout-test" doesn't freeze. BUG=589818, 590117 Committed: https://crrev.com/f38eb05f670c191e2800af303d0e9673c32dc5c1 Cr-Commit-Position: refs/heads/master@{#378371}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Add a comment to renderer.sb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M content/renderer/renderer.sb View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/Mac10_11_Expectations View 1 2 3 chunks +12 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
tkent
rsesek@, kerrnel@, would you review this please?
4 years, 10 months ago (2016-02-25 14:59:17 UTC) #2
Greg K
On 2016/02/25 14:59:17, tkent wrote: > rsesek@, kerrnel@, would you review this please? It looks ...
4 years, 10 months ago (2016-02-25 23:26:07 UTC) #4
tkent
On 2016/02/25 at 23:26:07, kerrnel wrote: > It looks like the patch failed to apply ...
4 years, 10 months ago (2016-02-25 23:44:19 UTC) #5
Robert Sesek
I left some comments on the bug. I'd like to resolve the discussion before committing ...
4 years, 10 months ago (2016-02-26 19:40:48 UTC) #6
Robert Sesek
https://codereview.chromium.org/1727363005/diff/20001/content/renderer/renderer.sb File content/renderer/renderer.sb (right): https://codereview.chromium.org/1727363005/diff/20001/content/renderer/renderer.sb#newcode39 content/renderer/renderer.sb:39: (literal "/usr/lib/libcrypto.0.9.8.dylib") Can you annotate this line and line ...
4 years, 9 months ago (2016-02-29 16:10:32 UTC) #7
tkent
https://codereview.chromium.org/1727363005/diff/20001/content/renderer/renderer.sb File content/renderer/renderer.sb (right): https://codereview.chromium.org/1727363005/diff/20001/content/renderer/renderer.sb#newcode39 content/renderer/renderer.sb:39: (literal "/usr/lib/libcrypto.0.9.8.dylib") On 2016/02/29 at 16:10:32, Robert Sesek wrote: ...
4 years, 9 months ago (2016-03-01 00:35:28 UTC) #9
Robert Sesek
lgtm
4 years, 9 months ago (2016-03-01 00:57:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727363005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727363005/40001
4 years, 9 months ago (2016-03-01 02:10:16 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-01 02:20:15 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 02:21:10 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f38eb05f670c191e2800af303d0e9673c32dc5c1
Cr-Commit-Position: refs/heads/master@{#378371}

Powered by Google App Engine
This is Rietveld 408576698