Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1727363004: trim DM fat (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

trim DM fat - cuts out a few fringe features like logs and notes tallies - moves vetos and blacklisting earlier so they're never really seen - many string strength reductions, either to const SkString& or const char* CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1727363004 Committed: https://skia.googlesource.com/skia/+/3eed7ddb25408cdd1c437e65728bac115aeacbd1

Patch Set 1 #

Patch Set 2 : lock #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -76 lines) Patch
M dm/DM.cpp View 1 2 16 chunks +38 lines, -76 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727363004/1
4 years, 10 months ago (2016-02-25 00:04:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727363004/20001
4 years, 10 months ago (2016-02-25 00:16:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 00:39:04 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727363004/40001
4 years, 10 months ago (2016-02-25 02:08:04 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 03:03:33 UTC) #12
mtklein
lgtm
4 years, 10 months ago (2016-02-25 03:06:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727363004/40001
4 years, 10 months ago (2016-02-25 03:06:22 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 03:07:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3eed7ddb25408cdd1c437e65728bac115aeacbd1

Powered by Google App Engine
This is Rietveld 408576698